Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issue 1444233002: Change responsive-test.js neutral keyframe format (Closed)

Created:
5 years, 1 month ago by alancutter (OOO until 2018)
Modified:
5 years, 1 month ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@_responsiveHarnessWebAnimations
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change responsive-test.js neutral keyframe format This changes the responsive animations test harness API's handling of neutral keyframes. Instead of an empty string neutral keyframes are specified by omitting the from/to keyframe value. This makes the API consistent with element.animate() and svg-attribute-interpolation/resources/interpolation-test.js. BUG=530436 Committed: https://crrev.com/80317defa2ac7c394dc66b72e5495155fa522b7d Cr-Commit-Position: refs/heads/master@{#360017}

Patch Set 1 #

Patch Set 2 : ebased #

Messages

Total messages: 21 (10 generated)
alancutter (OOO until 2018)
5 years, 1 month ago (2015-11-17 02:03:06 UTC) #4
Eric Willigers
lgtm I notice that all of our animations/responsive/ layout tests have neutral 'from' values and ...
5 years, 1 month ago (2015-11-17 02:25:17 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1444233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1444233002/1
5 years, 1 month ago (2015-11-17 02:27:58 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/141621)
5 years, 1 month ago (2015-11-17 02:42:03 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1444233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1444233002/1
5 years, 1 month ago (2015-11-17 03:43:28 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1444233002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1444233002/20001
5 years, 1 month ago (2015-11-17 04:03:33 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-17 04:49:08 UTC) #15
alancutter (OOO until 2018)
On 2015/11/17 at 02:25:17, ericwilligers wrote: > lgtm > > I notice that all of ...
5 years, 1 month ago (2015-11-17 05:45:35 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1444233002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1444233002/20001
5 years, 1 month ago (2015-11-17 05:45:55 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-17 05:58:46 UTC) #20
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 06:00:29 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/80317defa2ac7c394dc66b72e5495155fa522b7d
Cr-Commit-Position: refs/heads/master@{#360017}

Powered by Google App Engine
This is Rietveld 408576698