Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1449803002: Move SVG paint/color properties into CSSPropertyParser (Closed)

Created:
5 years, 1 month ago by rwlbuis
Modified:
5 years, 1 month ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move SVG paint/color properties into CSSPropertyParser Move SVG paint/color related properties from LegacyCSSPropertyParser into CSSPropertyParser. BUG=499780 Committed: https://crrev.com/b0ed7040ca6afc56499cec7ea410962cd5322090 Cr-Commit-Position: refs/heads/master@{#360000}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -38 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 3 chunks +28 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp View 2 chunks +5 lines, -38 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
rwlbuis
PTAL.
5 years, 1 month ago (2015-11-16 01:49:10 UTC) #3
Timothy Loh
On 2015/11/16 01:49:10, rwlbuis wrote: > PTAL. lgtm
5 years, 1 month ago (2015-11-16 23:58:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1449803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1449803002/1
5 years, 1 month ago (2015-11-17 01:00:04 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/141498)
5 years, 1 month ago (2015-11-17 02:05:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1449803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1449803002/1
5 years, 1 month ago (2015-11-17 02:10:47 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/141590)
5 years, 1 month ago (2015-11-17 02:51:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1449803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1449803002/1
5 years, 1 month ago (2015-11-17 03:12:49 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-17 04:23:26 UTC) #15
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 04:24:25 UTC) #16
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b0ed7040ca6afc56499cec7ea410962cd5322090
Cr-Commit-Position: refs/heads/master@{#360000}

Powered by Google App Engine
This is Rietveld 408576698