Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Side by Side Diff: third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp

Issue 1449803002: Move SVG paint/color properties into CSSPropertyParser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2003 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * Copyright (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 4 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
5 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com> 5 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
6 * Copyright (C) 2008 Eric Seidel <eric@webkit.org> 6 * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
8 * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved. 8 * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved.
9 * Copyright (C) 2012 Intel Corporation. All rights reserved. 9 * Copyright (C) 2012 Intel Corporation. All rights reserved.
10 * 10 *
(...skipping 1149 matching lines...) Expand 10 before | Expand all | Expand 10 after
1160 case CSSPropertyWebkitBorderBeforeWidth: 1160 case CSSPropertyWebkitBorderBeforeWidth:
1161 case CSSPropertyWebkitBorderAfterWidth: 1161 case CSSPropertyWebkitBorderAfterWidth:
1162 case CSSPropertyWebkitBorderStart: 1162 case CSSPropertyWebkitBorderStart:
1163 case CSSPropertyWebkitBorderEnd: 1163 case CSSPropertyWebkitBorderEnd:
1164 case CSSPropertyWebkitBorderBefore: 1164 case CSSPropertyWebkitBorderBefore:
1165 case CSSPropertyWebkitBorderAfter: 1165 case CSSPropertyWebkitBorderAfter:
1166 case CSSPropertyWebkitTextStroke: 1166 case CSSPropertyWebkitTextStroke:
1167 case CSSPropertyWebkitTextStrokeColor: 1167 case CSSPropertyWebkitTextStrokeColor:
1168 case CSSPropertyWebkitTextStrokeWidth: 1168 case CSSPropertyWebkitTextStrokeWidth:
1169 case CSSPropertyTransform: 1169 case CSSPropertyTransform:
1170 case CSSPropertyFill:
1171 case CSSPropertyStroke:
1172 case CSSPropertyStopColor:
1173 case CSSPropertyFloodColor:
1174 case CSSPropertyLightingColor:
1170 validPrimitive = false; 1175 validPrimitive = false;
1171 break; 1176 break;
1172 1177
1173 case CSSPropertyScrollSnapPointsX: 1178 case CSSPropertyScrollSnapPointsX:
1174 case CSSPropertyScrollSnapPointsY: 1179 case CSSPropertyScrollSnapPointsY:
1175 parsedValue = parseScrollSnapPoints(); 1180 parsedValue = parseScrollSnapPoints();
1176 break; 1181 break;
1177 case CSSPropertyScrollSnapCoordinate: 1182 case CSSPropertyScrollSnapCoordinate:
1178 parsedValue = parseScrollSnapCoordinate(); 1183 parsedValue = parseScrollSnapCoordinate();
1179 break; 1184 break;
(...skipping 4309 matching lines...) Expand 10 before | Expand all | Expand 10 after
5489 case CSSPropertyFillOpacity: 5494 case CSSPropertyFillOpacity:
5490 case CSSPropertyStopOpacity: 5495 case CSSPropertyStopOpacity:
5491 case CSSPropertyFloodOpacity: 5496 case CSSPropertyFloodOpacity:
5492 validPrimitive = validUnit(value, FNumber | FPercent, SVGAttributeMode); 5497 validPrimitive = validUnit(value, FNumber | FPercent, SVGAttributeMode);
5493 break; 5498 break;
5494 5499
5495 /* Start of supported CSS properties with validation. This is needed for par seShortHand to work 5500 /* Start of supported CSS properties with validation. This is needed for par seShortHand to work
5496 * correctly and allows optimization in applyRule(..) 5501 * correctly and allows optimization in applyRule(..)
5497 */ 5502 */
5498 5503
5499 case CSSPropertyFill: // <paint> | inherit
5500 case CSSPropertyStroke: // <paint> | inherit
5501 {
5502 if (id == CSSValueNone) {
5503 parsedValue = cssValuePool().createIdentifierValue(id);
5504 } else if (value->m_unit == CSSParserValue::URI) {
5505 if (m_valueList->next()) {
5506 RefPtrWillBeRawPtr<CSSValueList> values = CSSValueList::crea teSpaceSeparated();
5507 values->append(CSSURIValue::create(value->string));
5508 if (m_valueList->current()->id == CSSValueNone)
5509 parsedValue = cssValuePool().createIdentifierValue(m_val ueList->current()->id);
5510 else
5511 parsedValue = parseColor(m_valueList->current());
5512 if (parsedValue) {
5513 values->append(parsedValue);
5514 parsedValue = values;
5515 }
5516 }
5517 if (!parsedValue)
5518 parsedValue = CSSURIValue::create(value->string);
5519 } else {
5520 parsedValue = parseColor(m_valueList->current());
5521 }
5522
5523 if (parsedValue)
5524 m_valueList->next();
5525 }
5526 break;
5527
5528 case CSSPropertyStopColor: // TODO : icccolor
5529 case CSSPropertyFloodColor:
5530 case CSSPropertyLightingColor:
5531 parsedValue = parseColor(m_valueList->current());
5532 if (parsedValue)
5533 m_valueList->next();
5534
5535 break;
5536
5537 case CSSPropertyPaintOrder: 5504 case CSSPropertyPaintOrder:
5538 if (m_valueList->size() == 1 && id == CSSValueNormal) 5505 if (m_valueList->size() == 1 && id == CSSValueNormal)
5539 validPrimitive = true; 5506 validPrimitive = true;
5540 else if ((parsedValue = parsePaintOrder())) 5507 else if ((parsedValue = parsePaintOrder()))
5541 m_valueList->next(); 5508 m_valueList->next();
5542 break; 5509 break;
5543 5510
5544 case CSSPropertyStrokeWidth: // <length> | inherit 5511 case CSSPropertyStrokeWidth: // <length> | inherit
5545 case CSSPropertyStrokeDashoffset: 5512 case CSSPropertyStrokeDashoffset:
5546 case CSSPropertyCx: 5513 case CSSPropertyCx:
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
5681 } 5648 }
5682 break; 5649 break;
5683 default: 5650 default:
5684 ASSERT_NOT_REACHED(); 5651 ASSERT_NOT_REACHED();
5685 } 5652 }
5686 5653
5687 return paintOrderList.release(); 5654 return paintOrderList.release();
5688 } 5655 }
5689 5656
5690 } // namespace blink 5657 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698