Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp

Issue 1449803002: Move SVG paint/color properties into CSSPropertyParser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp
diff --git a/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp b/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp
index de2b40b635716eb88c6b6509bdaa04cc7967b693..10a9dbd61fe546c99d42a87827ad833cbb52ddeb 100644
--- a/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp
+++ b/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp
@@ -1167,6 +1167,11 @@ bool CSSPropertyParser::parseValue(CSSPropertyID unresolvedProperty, bool import
case CSSPropertyWebkitTextStrokeColor:
case CSSPropertyWebkitTextStrokeWidth:
case CSSPropertyTransform:
+ case CSSPropertyFill:
+ case CSSPropertyStroke:
+ case CSSPropertyStopColor:
+ case CSSPropertyFloodColor:
+ case CSSPropertyLightingColor:
validPrimitive = false;
break;
@@ -5496,44 +5501,6 @@ bool CSSPropertyParser::parseSVGValue(CSSPropertyID propId, bool important)
* correctly and allows optimization in applyRule(..)
*/
- case CSSPropertyFill: // <paint> | inherit
- case CSSPropertyStroke: // <paint> | inherit
- {
- if (id == CSSValueNone) {
- parsedValue = cssValuePool().createIdentifierValue(id);
- } else if (value->m_unit == CSSParserValue::URI) {
- if (m_valueList->next()) {
- RefPtrWillBeRawPtr<CSSValueList> values = CSSValueList::createSpaceSeparated();
- values->append(CSSURIValue::create(value->string));
- if (m_valueList->current()->id == CSSValueNone)
- parsedValue = cssValuePool().createIdentifierValue(m_valueList->current()->id);
- else
- parsedValue = parseColor(m_valueList->current());
- if (parsedValue) {
- values->append(parsedValue);
- parsedValue = values;
- }
- }
- if (!parsedValue)
- parsedValue = CSSURIValue::create(value->string);
- } else {
- parsedValue = parseColor(m_valueList->current());
- }
-
- if (parsedValue)
- m_valueList->next();
- }
- break;
-
- case CSSPropertyStopColor: // TODO : icccolor
- case CSSPropertyFloodColor:
- case CSSPropertyLightingColor:
- parsedValue = parseColor(m_valueList->current());
- if (parsedValue)
- m_valueList->next();
-
- break;
-
case CSSPropertyPaintOrder:
if (m_valueList->size() == 1 && id == CSSValueNormal)
validPrimitive = true;
« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698