process sorter analysis request(s)

process sorter analysis request(s)

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/6a5ac59b9c02ed0ac3afa23c648597484a14ff7f

[danrubel, 2015-11-17 07:06:13]

danrubel@google.com changed reviewers:
+ brianwilkerson@google.com

[danrubel, 2015-11-17 07:06:13]

Addresses comment
https://codereview.chromium.org/1447503002/diff/1/pkg/analysis_server/lib/src...

[Brian Wilkerson, 2015-11-17 15:11:38]

https://codereview.chromium.org/1449333002/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart
(right):

https://codereview.chromium.org/1449333002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart:194:
sendResults(request, todo.isEmpty);
If I understand correctly, this will only work if the `sort` method returns
`null`. If it actually needed additional results we would end up sending the
results before the results could be computed. If that's true, we should fail
quickly until we've implemented the rest of the support for it.

And this will necessitate that every method that could eventually invoke this
method be made asynchronous. Is it really worth while in order to allow sorting
to request additional results? Would it be better / possible to allow the
suggestions to capture enough information that we don't need more data in order
to sort them?

[danrubel, 2015-11-17 18:35:44]

PTAL

https://codereview.chromium.org/1449333002/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart
(right):

https://codereview.chromium.org/1449333002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart:194:
sendResults(request, todo.isEmpty);
On 2015/11/17 15:11:37, Brian Wilkerson wrote:
> If I understand correctly, this will only work if the `sort` method returns
> `null`. If it actually needed additional results we would end up sending the
> results before the results could be computed.

Correct. Per discussion, I will be adding support for this over the next several
CLs as I incrementally convert all contributors to the new API.

> And this will necessitate that every method that could eventually invoke this
> method be made asynchronous. Is it really worth while in order to allow
sorting
> to request additional results? Would it be better / possible to allow the
> suggestions to capture enough information that we don't need more data in
order
> to sort them?

The _processAnalysisRequest method will be used to process every analysis
request for every contributor. Requests for analysis from the sorter will be
handled in the same way after contributors. In addition, the computeFast and
computeFull methods will be combined into a single compute suggestions method.
Given this, I think supporting the sorter in this way will add only minimal
complexity.

[Brian Wilkerson, 2015-11-17 18:36:12]

LGTM

[danrubel, 2015-11-17 18:38:45]

Committed patchset #1 (id:1) manually as
6a5ac59b9c02ed0ac3afa23c648597484a14ff7f (presubmit successful).