update completion sorter to new API

pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.completion.dart;
 
 import 'dart:async';
 
 import 'package:analysis_server/plugin/protocol/protocol.dart';
 import 'package:analysis_server/src/analysis_server.dart';
@@ skipping 163 matching lines @@
           }
         }
       }
 
       List<DartCompletionContributor> todo = new List.from(contributors);
       todo.removeWhere((DartCompletionContributor c) {
         return performance.logElapseTime('computeFast ${c.runtimeType}', () {
           return c.computeFast(request);
         });
       });
-      contributionSorter.sort(
-          new OldRequestWrapper(request), request.suggestions);
+      // TODO(danrubel) Process the AnalysisRequest returned by the
+      // contribution sorter. At this point, the target unit has been fully
+      // resolved, thus no need for additional resolution, but in the future...
+      contributionSorter.sort(request, request.suggestions);

[Brian Wilkerson, 2015/11/14 16:59:24]

Given that this one line will turn into multiple lines, it would be best to
extract it into its own method now.

Also, the comment is a little vague. I'm not sure I'll remember in 3 months what
needed to be done here. Assuming I understand now, I think the eventual code
needs to be

AnalysisRequest request = contributionSorter.sort(request, request.suggestions);
while (request != null) {
    Object result = ...;
    request = request.callback(request, result);
}

And I assume the "..." is implemented somewhere already as part of the previous
changes. We should either implement it now or add this code as a concrete
reminder.

[danrubel, 2015/11/17 06:58:45]

Good point. I'll address that in a subsequent CL.

[danrubel, 2015/11/17 23:12:54]

https://codereview.chromium.org/1449333002/

 
       if (todo.isEmpty) {
         sendResults(request, todo.isEmpty);
       }
       return todo;
     });
   }
 
   /**
    * If there is remaining work to be done, then wait for the unit to be
@@ skipping 20 matching lines @@
         int count = todo.length;
         todo.forEach((DartCompletionContributor c) {
           String name = c.runtimeType.toString();
           String completeTag = 'computeFull $name complete';
           performance.logStartTime(completeTag);
           performance.logElapseTime('computeFull $name', () {
             c.computeFull(request).then((bool changed) {
               performance.logElapseTime(completeTag);
               bool last = --count == 0;
               if (changed || last) {
-                contributionSorter.sort(
-                    new OldRequestWrapper(request), request.suggestions);
+                // TODO(danrubel) Process the AnalysisRequest returned by the
+                // contribution sorter. At this point, the target unit has been
+                // fully resolved, thus no need for additional resolution,
+                // but in the future...
+                contributionSorter.sort(request, request.suggestions);
                 sendResults(request, last);
               }
             });
           });
         });
       });
     });
   }
 
   @override
@@ skipping 252 matching lines @@
 
   @override
   CompletionTarget get target => request.target;
 
   @override
   CompilationUnit get unit => request.unit;
 
   @override
   String toString() => 'wrapped $request';
 }