Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1449263003: Subzero. ARM32. Introduces the ShAmtImm Operand. (Closed)

Created:
5 years, 1 month ago by John
Modified:
5 years, 1 month ago
Reviewers:
Jim Stichnoth, Karl, sehr
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero. ARM32. Introduces the ShAmtImm Operand. Creates a special OperandARM32 for representing imm5 used when performing a shift operation. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4076 R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=2758bb077495d7a88b3d66368b3d760de61cedc7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -46 lines) Patch
M src/IceInstARM32.h View 2 chunks +31 lines, -0 lines 0 comments Download
M src/IceInstARM32.cpp View 2 chunks +9 lines, -0 lines 0 comments Download
M src/IceTargetLoweringARM32.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/IceTargetLoweringARM32.cpp View 13 chunks +38 lines, -46 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
John
5 years, 1 month ago (2015-11-17 22:18:33 UTC) #2
Karl
lgtm
5 years, 1 month ago (2015-11-17 22:24:23 UTC) #3
John
Committed patchset #1 (id:1) manually as 2758bb077495d7a88b3d66368b3d760de61cedc7 (presubmit successful).
5 years, 1 month ago (2015-11-17 22:31:29 UTC) #4
Jim Stichnoth
5 years, 1 month ago (2015-11-22 03:13:44 UTC) #5
Message was sent while issue was closed.
necro lgtm

Powered by Google App Engine
This is Rietveld 408576698