Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1448893003: Disable incomplete image tests in nanobench (Closed)

Created:
5 years, 1 month ago by msarett
Modified:
5 years, 1 month ago
Reviewers:
stephana, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Disable incomplete image tests in nanobench BUG=skia: Committed: https://skia.googlesource.com/skia/+/a7a21cffe1d56d52bac9accd05001e9c970e76f3

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -6 lines) Patch
M tools/nanobench_flags.json View 6 chunks +120 lines, -6 lines 0 comments Download
M tools/nanobench_flags.py View 1 chunk +22 lines, -0 lines 1 comment Download

Depends on Patchset:

Issue 1188223002 Patch 60001

Messages

Total messages: 12 (6 generated)
msarett
5 years, 1 month ago (2015-11-16 16:24:53 UTC) #2
mtklein
lgtm https://codereview.chromium.org/1448893003/diff/60001/tools/nanobench_flags.py File tools/nanobench_flags.py (right): https://codereview.chromium.org/1448893003/diff/60001/tools/nanobench_flags.py#newcode96 tools/nanobench_flags.py:96: match.append('~inc0.gif') Next time you might consider: match.extend('~'+name for ...
5 years, 1 month ago (2015-11-16 16:30:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1448893003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1448893003/60001
5 years, 1 month ago (2015-11-16 16:30:42 UTC) #8
msarett
5 years, 1 month ago (2015-11-16 16:30:45 UTC) #10
stephana
On 2015/11/16 16:30:45, msarett wrote: lgtm and +1 mtklein's suggestion.
5 years, 1 month ago (2015-11-16 16:36:48 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-16 16:43:25 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 (id:60001) as
https://skia.googlesource.com/skia/+/a7a21cffe1d56d52bac9accd05001e9c970e76f3

Powered by Google App Engine
This is Rietveld 408576698