Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Side by Side Diff: tools/nanobench_flags.py

Issue 1448893003: Disable incomplete image tests in nanobench (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/nanobench_flags.json ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # 1 #
2 # Copyright 2015 Google Inc. 2 # Copyright 2015 Google Inc.
3 # 3 #
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 # 6 #
7 7
8 #!/usr/bin/env python 8 #!/usr/bin/env python
9 9
10 usage = ''' 10 usage = '''
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 # so defensively disable them in nanobench, too. 84 # so defensively disable them in nanobench, too.
85 # FIXME (scroggo): This may have just been due to SkImageDecoder's 85 # FIXME (scroggo): This may have just been due to SkImageDecoder's
86 # buildTileIndex leaking memory (https://bug.skia.org/4360). That is 86 # buildTileIndex leaking memory (https://bug.skia.org/4360). That is
87 # disabled by default for nanobench, so we may not need this. 87 # disabled by default for nanobench, so we may not need this.
88 # FIXME (scroggo): Share image blacklists between dm and nanobench? 88 # FIXME (scroggo): Share image blacklists between dm and nanobench?
89 if 'x86' in bot and not 'x86-64' in bot: 89 if 'x86' in bot and not 'x86-64' in bot:
90 match.append('~interlaced1.png') 90 match.append('~interlaced1.png')
91 match.append('~interlaced2.png') 91 match.append('~interlaced2.png')
92 match.append('~interlaced3.png') 92 match.append('~interlaced3.png')
93 93
94 # We do not need or want to benchmark the decodes of incomplete images.
95 # In fact, in nanobench we assert that the full image decode succeeds.
96 match.append('~inc0.gif')
mtklein 2015/11/16 16:30:29 Next time you might consider: match.extend('~'+na
97 match.append('~inc1.gif')
98 match.append('~incInterlaced.gif')
99 match.append('~inc0.jpg')
100 match.append('~incGray.jpg')
101 match.append('~inc0.wbmp')
102 match.append('~inc1.wbmp')
103 match.append('~inc0.webp')
104 match.append('~inc1.webp')
105 match.append('~inc0.ico')
106 match.append('~inc1.ico')
107 match.append('~inc0.png')
108 match.append('~inc1.png')
109 match.append('~inc2.png')
110 match.append('~inc12.png')
111 match.append('~inc13.png')
112 match.append('~inc14.png')
113 match.append('~inc0.webp')
114 match.append('~inc1.webp')
115
94 if match: 116 if match:
95 args.append('--match') 117 args.append('--match')
96 args.extend(match) 118 args.extend(match)
97 119
98 return args 120 return args
99 cov_end = lineno() # Don't care about code coverage past here. 121 cov_end = lineno() # Don't care about code coverage past here.
100 122
101 123
102 def self_test(): 124 def self_test():
103 import coverage # This way the bots don't need coverage.py to be installed. 125 import coverage # This way the bots don't need coverage.py to be installed.
(...skipping 29 matching lines...) Expand all
133 if len(sys.argv) == 2 and sys.argv[1] == 'test': 155 if len(sys.argv) == 2 and sys.argv[1] == 'test':
134 self_test() 156 self_test()
135 sys.exit(0) 157 sys.exit(0)
136 158
137 if len(sys.argv) != 3: 159 if len(sys.argv) != 3:
138 print usage 160 print usage
139 sys.exit(1) 161 sys.exit(1)
140 162
141 with open(sys.argv[1], 'w') as out: 163 with open(sys.argv[1], 'w') as out:
142 json.dump(get_args(sys.argv[2]), out) 164 json.dump(get_args(sys.argv[2]), out)
OLDNEW
« no previous file with comments | « tools/nanobench_flags.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698