update completion sorter to new API

pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart

Index: pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart b/pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart
index 161197d513a05e5008bb9277578b370f14357f4f..0a23c17499274fad7532f35080057071c0ff8b61 100644
--- a/pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart
+++ b/pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart
@@ -181,8 +181,10 @@ class DartCompletionManager extends CompletionManager {
           return c.computeFast(request);
         });
       });
-      contributionSorter.sort(
-          new OldRequestWrapper(request), request.suggestions);
+      // TODO(danrubel) Process the AnalysisRequest returned by the
+      // contribution sorter. At this point, the target unit has been fully
+      // resolved, thus no need for additional resolution, but in the future...
+      contributionSorter.sort(request, request.suggestions);

[Brian Wilkerson, 2015/11/14 16:59:24]

Given that this one line will turn into multiple lines, it would be best to
extract it into its own method now.

Also, the comment is a little vague. I'm not sure I'll remember in 3 months what
needed to be done here. Assuming I understand now, I think the eventual code
needs to be

AnalysisRequest request = contributionSorter.sort(request, request.suggestions);
while (request != null) {
    Object result = ...;
    request = request.callback(request, result);
}

And I assume the "..." is implemented somewhere already as part of the previous
changes. We should either implement it now or add this code as a concrete
reminder.

[danrubel, 2015/11/17 06:58:45]

Good point. I'll address that in a subsequent CL.

[danrubel, 2015/11/17 23:12:54]

https://codereview.chromium.org/1449333002/

 
       if (todo.isEmpty) {
         sendResults(request, todo.isEmpty);
@@ -223,8 +225,11 @@ class DartCompletionManager extends CompletionManager {
               performance.logElapseTime(completeTag);
               bool last = --count == 0;
               if (changed || last) {
-                contributionSorter.sort(
-                    new OldRequestWrapper(request), request.suggestions);
+                // TODO(danrubel) Process the AnalysisRequest returned by the
+                // contribution sorter. At this point, the target unit has been
+                // fully resolved, thus no need for additional resolution,
+                // but in the future...
+                contributionSorter.sort(request, request.suggestions);
                 sendResults(request, last);
               }
             });