ExternalDataUseObserver matches package names

chrome/browser/android/data_usage/external_data_use_observer.cc

Index: chrome/browser/android/data_usage/external_data_use_observer.cc
diff --git a/chrome/browser/android/data_usage/external_data_use_observer.cc b/chrome/browser/android/data_usage/external_data_use_observer.cc
index 23ecc6dd3857d1736a394cdb298952d6bd2f3f43..e8ae9487cb11fda3560b0d174c5fded424881c77 100644
--- a/chrome/browser/android/data_usage/external_data_use_observer.cc
+++ b/chrome/browser/android/data_usage/external_data_use_observer.cc
@@ -397,6 +397,25 @@ bool ExternalDataUseObserver::Matches(const GURL& gurl,
   return false;
 }
 
+bool ExternalDataUseObserver::MatchesAppPackageName(
+    const std::string& app_package_name,
+    std::string* label) const {
+  DCHECK(thread_checker_.CalledOnValidThread());
+  *label = "";
+
+  if (app_package_name.empty())
+    return false;
+
+  for (size_t i = 0; i < matching_rules_.size(); ++i) {

[sclittle, 2015/11/18 22:17:07]

nit: use range-based for loop, e.g. something like

for (const auto* rule : matching_rules_) {
  if (app_package_name == rule->app_package_name()) {
...

[tbansal1, 2015/11/18 23:46:43]

Done.

+    if (app_package_name == matching_rules_[i]->app_package_name()) {
+      *label = matching_rules_[i]->label();
+      return true;
+    }
+  }
+
+  return false;
+}
+
 ExternalDataUseObserver::DataUseReportKey::DataUseReportKey(
     const std::string& label,
     net::NetworkChangeNotifier::ConnectionType connection_type,
@@ -450,6 +469,11 @@ const re2::RE2* ExternalDataUseObserver::MatchingRule::pattern() const {
   return pattern_.get();
 }
 
+const std::string& ExternalDataUseObserver::MatchingRule::app_package_name()
+    const {
+  return app_package_name_;
+}
+
 const std::string& ExternalDataUseObserver::MatchingRule::label() const {
   return label_;
 }