ExternalDataUseObserver matches package names

chrome/browser/android/data_usage/external_data_use_observer.h

Index: chrome/browser/android/data_usage/external_data_use_observer.h
diff --git a/chrome/browser/android/data_usage/external_data_use_observer.h b/chrome/browser/android/data_usage/external_data_use_observer.h
index 86706c5041d1d05b4bb7e538faf207320a09c8df..deecd5dab545fe54b6e2e74b9ea2c23cee003242 100644
--- a/chrome/browser/android/data_usage/external_data_use_observer.h
+++ b/chrome/browser/android/data_usage/external_data_use_observer.h
@@ -91,6 +91,12 @@ class ExternalDataUseObserver : public data_usage::DataUseAggregator::Observer {
   // matching rule's label.
   bool Matches(const GURL& gurl, std::string* label) const;
 
+  // Returns true if the |app_package_name| matches the registered package
+  // names. |label| must not be null. If a match is found, the |label| is set

[Raj, 2015/11/18 18:36:51]

nits:
change |label| to |output_label| for more clarity.

[tbansal1, 2015/11/18 18:50:50]

I think it is clear that since it is a pointer and from the comments, that it
will be modified.

+  // to the matching rule's label.
+  bool MatchesAppPackageName(const std::string& app_package_name,
+                             std::string* label) const;
+
   DataUseTabModel* data_use_tab_model() const {
     return data_use_tab_model_.get();
   }
@@ -183,6 +189,7 @@ class ExternalDataUseObserver : public data_usage::DataUseAggregator::Observer {
     ~MatchingRule();
 
     const re2::RE2* pattern() const;
+    const std::string& app_package_name() const;

[Raj, 2015/11/18 18:36:51]

nits:
If its only used in tests, consider making the test class as friend to
MatchingRule.
Not sure if this is intended to be used by new code.

[tbansal1, 2015/11/18 18:50:50]

this is used in external_data_use_observer.cc

     const std::string& label() const;
 
    private: