ExternalDataUseObserver matches package names

chrome/browser/android/data_usage/external_data_use_observer.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/data_usage/external_data_use_observer.h"
 
 #include <utility>
 
 #include "base/android/jni_string.h"
 #include "base/containers/hash_tables.h"
@@ skipping 379 matching lines @@
     const re2::RE2* pattern = matching_rules_[i]->pattern();
     if (re2::RE2::FullMatch(gurl.spec(), *pattern)) {
       *label = matching_rules_[i]->label();
       return true;
     }
   }
 
   return false;
 }
 
+bool ExternalDataUseObserver::MatchesAppPackageName(
+    const std::string& app_package_name,
+    std::string* label) const {
+  DCHECK(thread_checker_.CalledOnValidThread());
+  *label = "";
+
+  if (app_package_name.empty())
+    return false;
+
+  for (size_t i = 0; i < matching_rules_.size(); ++i) {

[sclittle, 2015/11/18 22:17:07]

nit: use range-based for loop, e.g. something like

for (const auto* rule : matching_rules_) {
  if (app_package_name == rule->app_package_name()) {
...

[tbansal1, 2015/11/18 23:46:43]

Done.

+    if (app_package_name == matching_rules_[i]->app_package_name()) {
+      *label = matching_rules_[i]->label();
+      return true;
+    }
+  }
+
+  return false;
+}
+
 ExternalDataUseObserver::DataUseReportKey::DataUseReportKey(
     const std::string& label,
     net::NetworkChangeNotifier::ConnectionType connection_type,
     const std::string& mcc_mnc)
     : label(label), connection_type(connection_type), mcc_mnc(mcc_mnc) {}
 
 bool ExternalDataUseObserver::DataUseReportKey::operator==(
     const DataUseReportKey& other) const {
   return label == other.label && connection_type == other.connection_type &&
          mcc_mnc == other.mcc_mnc;
@@ skipping 33 matching lines @@
     : app_package_name_(app_package_name),
       pattern_(pattern.Pass()),
       label_(label) {}
 
 ExternalDataUseObserver::MatchingRule::~MatchingRule() {}
 
 const re2::RE2* ExternalDataUseObserver::MatchingRule::pattern() const {
   return pattern_.get();
 }
 
+const std::string& ExternalDataUseObserver::MatchingRule::app_package_name()
+    const {
+  return app_package_name_;
+}
+
 const std::string& ExternalDataUseObserver::MatchingRule::label() const {
   return label_;
 }
 
 bool RegisterExternalDataUseObserver(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace android
 
 }  // namespace chrome