Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Issue 1447273003: Make the FloatSize constructor from an IntSize explicit. (Closed)

Created:
5 years, 1 month ago by chrishtr
Modified:
5 years, 1 month ago
Reviewers:
f(malita)
CC:
darktears, apavlov+blink_chromium.org, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, blink-reviews-style_chromium.org, Rik, chromium-reviews, danakj, dcheng, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, f(malita), fs, gyuyoung2, jbroman, jchaffraix+rendering, Justin Novosad, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+graphicswatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, vmpstr+blinkwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make the FloatSize constructor from an IntSize explicit. Committed: https://crrev.com/49be7303ead3a0429c0c372aab7148e4376409a7 Cr-Commit-Position: refs/heads/master@{#360496}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -93 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSGradientValue.cpp View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/PageScaleConstraintsSet.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/frame/VisualViewport.cpp View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 12 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/shapes/BoxShapeTest.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/BoxBorderPainter.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ThemePainterMac.mm View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleGeneratedImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/filters/SVGFEImage.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/DragImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/geometry/FloatSize.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/CrossfadeGeneratedImage.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GeneratedImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/Image.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBufferSurface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/FullscreenController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/PageOverlay.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/RotationViewportAnchor.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/ViewportTest.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/VisualViewportTest.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
chrishtr
Florin: this is followup related to the int coercion patch you committed.
5 years, 1 month ago (2015-11-17 19:30:29 UTC) #3
f(malita)
LGTM % Mac fixes.
5 years, 1 month ago (2015-11-17 19:58:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1447273003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1447273003/20001
5 years, 1 month ago (2015-11-17 23:57:39 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/142175)
5 years, 1 month ago (2015-11-18 00:15:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1447273003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1447273003/40001
5 years, 1 month ago (2015-11-18 23:19:59 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/125067) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 1 month ago (2015-11-18 23:53:47 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1447273003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1447273003/60001
5 years, 1 month ago (2015-11-19 00:34:29 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 1 month ago (2015-11-19 02:31:23 UTC) #18
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 02:32:21 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/49be7303ead3a0429c0c372aab7148e4376409a7
Cr-Commit-Position: refs/heads/master@{#360496}

Powered by Google App Engine
This is Rietveld 408576698