third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.cpp - Issue 1447273003: Make the FloatSize constructor from an IntSize explicit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.cpp

Issue 1447273003: Make the FloatSize constructor from an IntSize explicit. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/ImageBufferSurface.cpp ('k') | third_party/WebKit/Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.cpp b/third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.cpp

index 248f4d55595a39277c05b4c8368eae7ad6cb6a97..b96fad7b4418579a08c6eb3051971f445407037d 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.cpp

+++ b/third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.cpp

@@ -59,7 +59,7 @@ FloatRect FEConvolveMatrix::mapPaintRect(const FloatRect& rect, bool forward)

FloatRect result = rect;

if (parametersValid()) {

result.moveBy(forward ? -m_targetOffset : m_targetOffset - m_kernelSize);

- result.expand(m_kernelSize);

+ result.expand(FloatSize(m_kernelSize));

}

return result;

}

@@ -181,7 +181,7 @@ TextStream& FEConvolveMatrix::externalRepresentation(TextStream& ts, int indent)

writeIndent(ts, indent);

ts << "[feConvolveMatrix";

FilterEffect::externalRepresentation(ts);

- ts << " order=\"" << m_kernelSize << "\" "

+ ts << " order=\"" << FloatSize(m_kernelSize) << "\" "

<< "kernelMatrix=\"" << m_kernelMatrix << "\" "

<< "divisor=\"" << m_divisor << "\" "

<< "bias=\"" << m_bias << "\" "