third_party/WebKit/Source/core/paint/BoxBorderPainter.cpp - Issue 1447273003: Make the FloatSize constructor from an IntSize explicit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/BoxBorderPainter.cpp

Issue 1447273003: Make the FloatSize constructor from an IntSize explicit. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/shapes/BoxShapeTest.cpp ('k') | third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/BoxBorderPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/BoxBorderPainter.cpp b/third_party/WebKit/Source/core/paint/BoxBorderPainter.cpp

index c9aeef9006f78f2db774b943b88cbea25904256f..5927d1acef1bbf6222d925d58af87d01ecced3c3 100644

--- a/third_party/WebKit/Source/core/paint/BoxBorderPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/BoxBorderPainter.cpp

@@ -184,8 +184,8 @@ FloatRoundedRect calculateAdjustedInnerBorder(const FloatRoundedRect& innerBorde

if (!newRadii.topLeft().width())

newRect.move(-overshoot, 0);

}

- newRadii.setBottomLeft(IntSize(0, 0));

- newRadii.setBottomRight(IntSize(0, 0));

+ newRadii.setBottomLeft(FloatSize(0, 0));

+ newRadii.setBottomRight(FloatSize(0, 0));

maxRadii = std::max(newRadii.topLeft().height(), newRadii.topRight().height());

if (maxRadii > newRect.height())

newRect.setHeight(maxRadii);

@@ -198,8 +198,8 @@ FloatRoundedRect calculateAdjustedInnerBorder(const FloatRoundedRect& innerBorde

if (!newRadii.bottomLeft().width())

newRect.move(-overshoot, 0);

}

- newRadii.setTopLeft(IntSize(0, 0));

- newRadii.setTopRight(IntSize(0, 0));

+ newRadii.setTopLeft(FloatSize(0, 0));

+ newRadii.setTopRight(FloatSize(0, 0));

maxRadii = std::max(newRadii.bottomLeft().height(), newRadii.bottomRight().height());

if (maxRadii > newRect.height()) {

newRect.move(0, newRect.height() - maxRadii);

@@ -214,8 +214,8 @@ FloatRoundedRect calculateAdjustedInnerBorder(const FloatRoundedRect& innerBorde

if (!newRadii.topLeft().height())

newRect.move(0, -overshoot);

}

- newRadii.setTopRight(IntSize(0, 0));

- newRadii.setBottomRight(IntSize(0, 0));

+ newRadii.setTopRight(FloatSize(0, 0));

+ newRadii.setBottomRight(FloatSize(0, 0));

maxRadii = std::max(newRadii.topLeft().width(), newRadii.bottomLeft().width());

if (maxRadii > newRect.width())

newRect.setWidth(maxRadii);

@@ -228,8 +228,8 @@ FloatRoundedRect calculateAdjustedInnerBorder(const FloatRoundedRect& innerBorde

if (!newRadii.topRight().height())

newRect.move(0, -overshoot);

}

- newRadii.setTopLeft(IntSize(0, 0));

- newRadii.setBottomLeft(IntSize(0, 0));

+ newRadii.setTopLeft(FloatSize(0, 0));

+ newRadii.setBottomLeft(FloatSize(0, 0));

maxRadii = std::max(newRadii.topRight().width(), newRadii.bottomRight().width());

if (maxRadii > newRect.width()) {

newRect.move(newRect.width() - maxRadii, 0);