Index: components/crash/content/browser/crash_dump_manager_android.h |
diff --git a/components/crash/content/browser/crash_dump_manager_android.h b/components/crash/content/browser/crash_dump_manager_android.h |
index e3f2391efe775851903cdfa88b6617599c646109..ed32cd28b8cd3356303c4f3128d6a3a8acc5b667 100644 |
--- a/components/crash/content/browser/crash_dump_manager_android.h |
+++ b/components/crash/content/browser/crash_dump_manager_android.h |
@@ -48,8 +48,17 @@ class CrashDumpManager : public content::BrowserChildProcessObserver, |
private: |
typedef std::map<int, base::FilePath> ChildProcessIDToMinidumpPath; |
+ // This enum is used to back a UMA histogram, and must be treated as |
+ // append-only. |
+ enum ExitStatus { |
Yaron
2015/11/17 02:02:45
Please use IntDef instead: http://developer.androi
Peter Wen
2015/11/17 19:45:22
Switched to using IntDef in TabWebContentsObserver
|
+ EMPTY_MINIDUMP = 0, |
+ VALID_MINIDUMP = 1, |
+ COUNT = 2 |
+ }; |
+ |
static void ProcessMinidump(const base::FilePath& minidump_path, |
- base::ProcessHandle pid); |
+ base::ProcessHandle pid, |
+ bool recordExitStatus); |
// content::BrowserChildProcessObserver implementation: |
void BrowserChildProcessHostDisconnected( |
@@ -65,6 +74,9 @@ class CrashDumpManager : public content::BrowserChildProcessObserver, |
// Called on child process exit (including crash). |
void OnChildExit(int child_process_id, base::ProcessHandle pid); |
+ void OnChildExit(int child_process_id, |
Yaron
2015/11/17 02:02:46
Typically don't overload functions in C++: https:/
Peter Wen
2015/11/17 19:45:22
Done.
|
+ base::ProcessHandle pid, |
+ bool recordExitStatus); |
content::NotificationRegistrar notification_registrar_; |