Add stats to distinguish android renderer crashes.

components/crash/content/browser/crash_dump_manager_android.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_CRASH_CONTENT_BROWSER_CRASH_DUMP_MANAGER_ANDROID_H_
 #define COMPONENTS_CRASH_CONTENT_BROWSER_CRASH_DUMP_MANAGER_ANDROID_H_
 
 #include <map>
 
 #include "base/files/file.h"
@@ skipping 30 matching lines @@
 
   ~CrashDumpManager() override;
 
   // Returns a file that should be used to generate a minidump for the process
   // |child_process_id|.
   base::File CreateMinidumpFile(int child_process_id);
 
  private:
   typedef std::map<int, base::FilePath> ChildProcessIDToMinidumpPath;
 
+  // This enum is used to back a UMA histogram, and must be treated as
+  // append-only.
+  enum ExitStatus {

[Yaron, 2015/11/17 02:02:45]

Please use IntDef instead:
http://developer.android.com/reference/android/support/annotation/IntDef.html

[Peter Wen, 2015/11/17 19:45:22]

Switched to using IntDef in TabWebContentsObserver. Is there an equivalent in
C++?

+    EMPTY_MINIDUMP = 0,
+    VALID_MINIDUMP = 1,
+    COUNT = 2
+  };
+
   static void ProcessMinidump(const base::FilePath& minidump_path,
-                              base::ProcessHandle pid);
+                              base::ProcessHandle pid,
+                              bool recordExitStatus);
 
   // content::BrowserChildProcessObserver implementation:
   void BrowserChildProcessHostDisconnected(
       const content::ChildProcessData& data) override;
   void BrowserChildProcessCrashed(
       const content::ChildProcessData& data,
       int exit_code) override;
 
   // NotificationObserver implementation:
   void Observe(int type,
                const content::NotificationSource& source,
                const content::NotificationDetails& details) override;
 
   // Called on child process exit (including crash).
   void OnChildExit(int child_process_id, base::ProcessHandle pid);
+  void OnChildExit(int child_process_id,

[Yaron, 2015/11/17 02:02:46]

Typically don't overload functions in C++:
https://google.github.io/styleguide/cppguide.html#Function_Overloading

For that matter, just update callers - there aren't many

[Peter Wen, 2015/11/17 19:45:22]

Done.

+                   base::ProcessHandle pid,
+                   bool recordExitStatus);
 
   content::NotificationRegistrar notification_registrar_;
 
   // This map should only be accessed with its lock aquired as it is accessed
   // from the PROCESS_LAUNCHER and UI threads.
   base::Lock child_process_id_to_minidump_path_lock_;
   ChildProcessIDToMinidumpPath child_process_id_to_minidump_path_;
 
   base::FilePath crash_dump_dir_;
 
   static CrashDumpManager* instance_;
 
   DISALLOW_COPY_AND_ASSIGN(CrashDumpManager);
 };
 
 }  // namespace breakpad
 
 #endif  // COMPONENTS_CRASH_CONTENT_BROWSER_CRASH_DUMP_MANAGER_ANDROID_H_