Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java

Issue 1447213002: Add stats to distinguish android renderer crashes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java
index 755c9dfaf8e21153328a57674df5c1d4459da00c..3cd99b3ad8ce08f2e73e5223290d900b91dd39d3 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java
@@ -44,6 +44,14 @@ public class TabWebContentsObserver extends WebContentsObserver {
private static final int TAB_RENDERER_CRASH_STATUS_HIDDEN_IN_BACKGROUND_APP = 2;
private static final int TAB_RENDERER_CRASH_STATUS_MAX = 3;
+ // TabRendererExitStatus defined in tools/metrics/histograms/histograms.xml.
+ // Designed to replace TabRendererCrashStatus if numbers line up.
+ private static final int TAB_RENDERER_EXIT_STATUS_OOM_PROTECTED_IN_FOREGROUND_APP = 0;
+ private static final int TAB_RENDERER_EXIT_STATUS_OOM_PROTECTED_IN_BACKGROUND_APP = 1;
+ private static final int TAB_RENDERER_EXIT_STATUS_NOT_PROTECTED_IN_FOREGROUND_APP = 2;
+ private static final int TAB_RENDERER_EXIT_STATUS_NOT_PROTECTED_IN_BACKGROUND_APP = 3;
+ private static final int TAB_RENDERER_EXIT_STATUS_MAX = 4;
+
private final Tab mTab;
private int mThemeColor;
@@ -92,6 +100,25 @@ public class TabWebContentsObserver extends WebContentsObserver {
RecordHistogram.recordEnumeratedHistogram(
"Tab.RendererCrashStatus", rendererCrashStatus, TAB_RENDERER_CRASH_STATUS_MAX);
+ // This will replace TabRendererCrashStatus if numbers line up.
+ boolean applicationInForeground = ApplicationStatus.hasRunningActivities();
+ int rendererExitStatus = TAB_RENDERER_EXIT_STATUS_MAX;
+ if (processWasOomProtected) {
+ if (applicationInForeground) {
+ rendererExitStatus = TAB_RENDERER_EXIT_STATUS_OOM_PROTECTED_IN_FOREGROUND_APP;
+ } else {
+ rendererExitStatus = TAB_RENDERER_EXIT_STATUS_OOM_PROTECTED_IN_BACKGROUND_APP;
+ }
+ } else {
+ if (applicationInForeground) {
+ rendererExitStatus = TAB_RENDERER_EXIT_STATUS_NOT_PROTECTED_IN_FOREGROUND_APP;
+ } else {
+ rendererExitStatus = TAB_RENDERER_EXIT_STATUS_NOT_PROTECTED_IN_BACKGROUND_APP;
+ }
+ }
+ RecordHistogram.recordEnumeratedHistogram(
+ "Tab.RendererExitStatus", rendererExitStatus, TAB_RENDERER_EXIT_STATUS_MAX);
+
mTab.handleTabCrash();
boolean sadTabShown = mTab.isShowingSadTab();

Powered by Google App Engine
This is Rietveld 408576698