third_party/WebKit/Source/modules/credentialmanager/Credential.h - Issue 1446963002: CREDENTIAL: Teach Fetch to handle PasswordCredential objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/credentialmanager/Credential.h

Issue 1446963002: CREDENTIAL: Teach Fetch to handle PasswordCredential objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@opaque

Patch Set: Better Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/credentialmanager/passwordcredential-fetch.html ('K') | « third_party/WebKit/Source/core/dom/URLSearchParams.h ('k') | third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.h » ('j') | third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/credentialmanager/Credential.h

diff --git a/third_party/WebKit/Source/modules/credentialmanager/Credential.h b/third_party/WebKit/Source/modules/credentialmanager/Credential.h

index 54c24198bb53690dfbae8426ae8a7a42141ee4a0..6c94cb061dd988fb9f98f8ceebca577b9651b0d2 100644

--- a/third_party/WebKit/Source/modules/credentialmanager/Credential.h

+++ b/third_party/WebKit/Source/modules/credentialmanager/Credential.h

@@ -14,7 +14,7 @@ namespace blink {

class ExceptionState;

-class Credential : public GarbageCollected<Credential>, public ScriptWrappable {

+class Credential : public GarbageCollectedFinalized<Credential>, public ScriptWrappable {

philipj_slow 2015/11/17 15:53:59 Why was this change needed? I can't see a member t

Mike West 2015/11/18 09:12:51 I added `String` members to `PasswordCredential`,

philipj_slow 2015/11/18 10:00:05 Ah, a subclass, thanks!

DEFINE_WRAPPERTYPEINFO();

public:

// Credential.idl