CREDENTIAL: Teach Fetch to handle PasswordCredential objects.

third_party/WebKit/Source/modules/credentialmanager/Credential.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef Credential_h
 #define Credential_h
 
 #include "bindings/core/v8/ScriptWrappable.h"
 #include "platform/credentialmanager/PlatformCredential.h"
 #include "platform/heap/Handle.h"
 #include "platform/weborigin/KURL.h"
 
 namespace blink {
 
 class ExceptionState;
 
-class Credential : public GarbageCollected<Credential>, public ScriptWrappable {
+class Credential : public GarbageCollectedFinalized<Credential>, public ScriptWrappable {

[philipj_slow, 2015/11/17 15:53:59]

Why was this change needed? I can't see a member that has changed, or anything
obvious of that kind.

[Mike West, 2015/11/18 09:12:51]

I added `String` members to `PasswordCredential`, which subclasses `Credential`.
Assuming I've understood the error messages correctly, those need to be
finalized, so `Credential` needs to be finalized.

[philipj_slow, 2015/11/18 10:00:05]

Ah, a subclass, thanks!

     DEFINE_WRAPPERTYPEINFO();
 public:
     // Credential.idl
     const String& id() const { return m_platformCredential->id(); }
     const String& name() const { return m_platformCredential->name(); }
     const KURL& iconURL() const { return m_platformCredential->iconURL(); }
     const String& type() const { return m_platformCredential->type(); }
 
     DECLARE_VIRTUAL_TRACE();
 
     PlatformCredential* platformCredential() const { return m_platformCredential; }
 
 protected:
     Credential(PlatformCredential*);
     Credential(const String& id, const String& name, const KURL& icon);
 
     // Parses a string as a KURL. Throws an exception via |exceptionState| if an invalid URL is produced.
     static KURL parseStringAsURL(const String&, ExceptionState&);
 
     Member<PlatformCredential> m_platformCredential;
 };
 
 } // namespace blink
 
 #endif // Credential_h