Chromium Code Reviews

Unified Diff: third_party/WebKit/LayoutTests/http/tests/credentialmanager/passwordcredential-fetch.html

Issue 1446963002: CREDENTIAL: Teach Fetch to handle PasswordCredential objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@opaque
Patch Set: Better Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« third_party/WebKit/LayoutTests/http/tests/credentialmanager/passwordcredential-basics.html ('K') | « third_party/WebKit/LayoutTests/http/tests/credentialmanager/passwordcredential-basics.html ('k') | third_party/WebKit/LayoutTests/http/tests/credentialmanager/resources/echo-post.php » ('j') | third_party/WebKit/Source/modules/credentialmanager/Credential.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/http/tests/credentialmanager/passwordcredential-fetch.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/credentialmanager/passwordcredential-fetch.html b/third_party/WebKit/LayoutTests/http/tests/credentialmanager/passwordcredential-fetch.html
new file mode 100644
index 0000000000000000000000000000000000000000..c9e4e94b919a7434f8bcfb1db7ade94d270038db
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/http/tests/credentialmanager/passwordcredential-fetch.html
@@ -0,0 +1,157 @@
+<!DOCTYPE html>
+<title>Credential Manager: PasswordCredential basics.</title>
+<script src="../resources/testharness.js"></script>
+<script src="../resources/testharnessreport.js"></script>
+<script src="/serviceworker/resources/interfaces.js"></script>
+<script>
+async_test(function(t) {
philipj_slow 2015/11/17 15:53:59 I don't know if it will simplify or not, but there
Mike West 2015/11/18 09:12:51 Looks like a pretty reasonable simplification.
philipj_slow 2015/11/18 10:00:05 Yep, it turned out pretty nice!
+ var credential = new PasswordCredential({
+ id: 'id',
+ password: 'pencil',
+ name: 'name',
+ iconURL: 'https://example.com/icon.png'
+ });
+
+ fetch("./resources/echo-post.php", { body: credential, method: "POST" }).then(
+ t.step_func(function (r) {
+ r.json().then(
philipj_slow 2015/11/17 15:53:59 I think you could also flatten this kind of struct
Mike West 2015/11/18 09:12:50 This looks pretty cool to me!
+ t.step_func_done(function (j) {
+ assert_equals(j.username, 'id');
+ assert_equals(j.password, 'pencil');
+ }),
+ t.unreached_func("Should be able to read the body."));
+ }),
+ t.unreached_func("Should not reject")
+ );
+}, "Simple Fetch");
+
+async_test(function(t) {
+ var credential = new PasswordCredential({
+ id: 'id',
+ password: 'pencil',
+ name: 'name',
+ iconURL: 'https://example.com/icon.png'
+ });
+
+ credential.idName = "notUsername";
+ credential.passwordName = "notPassword";
+
+ fetch("./resources/echo-post.php", { body: credential, method: "POST" }).then(
+ t.step_func(function (r) {
+ r.json().then(
+ t.step_func_done(function (j) {
+ assert_equals(j.username, undefined);
+ assert_equals(j.password, undefined);
+ assert_equals(j.notUsername, 'id');
+ assert_equals(j.notPassword, 'pencil');
+ }),
+ t.unreached_func("Should be able to read the body."));
+ }),
+ t.unreached_func("Should not reject")
+ );
+}, "'idName' and 'passwordName'");
+
+async_test(function(t) {
+ var credential = new PasswordCredential({
+ id: 'id',
+ password: 'pencil',
+ name: 'name',
+ iconURL: 'https://example.com/icon.png'
+ });
+
+ var fd = new FormData();
+ credential.additionalData = fd;
+
+ fetch("./resources/echo-post.php", { body: credential, method: "POST" }).then(
+ t.step_func(function (r) {
+ r.json().then(
+ t.step_func_done(function (j) {
+ assert_equals(j.username, 'id');
+ assert_equals(j.password, 'pencil');
+ }),
+ t.unreached_func("Should be able to read the body."));
+ }),
+ t.unreached_func("Should not reject")
+ );
+}, "'additionalData': Empty FormData has no effect.");
+
+async_test(function(t) {
+ var credential = new PasswordCredential({
+ id: 'id',
+ password: 'pencil',
+ name: 'name',
+ iconURL: 'https://example.com/icon.png'
+ });
+
+ var fd = new FormData();
+ fd.append("excitingData", "exciting value");
+ fd.append("csrf", "[randomness]");
+ credential.additionalData = fd;
+
+ fetch("./resources/echo-post.php", { body: credential, method: "POST" }).then(
+ t.step_func(function (r) {
+ r.json().then(
+ t.step_func_done(function (j) {
+ assert_equals(j.username, 'id');
+ assert_equals(j.password, 'pencil');
+ assert_equals(j.excitingData, 'exciting value');
+ assert_equals(j.csrf, '[randomness]');
+ }),
+ t.unreached_func("Should be able to read the body."));
+ }),
+ t.unreached_func("Should not reject")
+ );
+}, "'additionalData': FormData properties are properly injected.");
philipj_slow 2015/11/17 15:53:59 The spec requires a specific order (idName+passwor
Mike West 2015/11/18 09:12:51 This is going to be difficult to do with FormData.
philipj_slow 2015/11/18 10:00:05 Fair enough :)
+
+async_test(function(t) {
+ var credential = new PasswordCredential({
+ id: 'id',
+ password: 'pencil',
+ name: 'name',
+ iconURL: 'https://example.com/icon.png'
+ });
+
+ var params = new URLSearchParams();
+ credential.additionalData = params;
+
+ fetch("./resources/echo-post.php", { body: credential, method: "POST" }).then(
+ t.step_func(function (r) {
+ r.json().then(
+ t.step_func_done(function (j) {
+ assert_equals(j.username, 'id');
+ assert_equals(j.password, 'pencil');
+ }),
+ t.unreached_func("Should be able to read the body."));
+ }),
+ t.unreached_func("Should not reject")
+ );
+}, "'additionalData': Empty URLSearchParams has no effect.");
+
+async_test(function(t) {
+ var credential = new PasswordCredential({
+ id: 'id',
+ password: 'pencil',
+ name: 'name',
+ iconURL: 'https://example.com/icon.png'
+ });
+
+ var params = new URLSearchParams();
+ params.append("excitingData", "exciting value");
+ params.append("csrf", "[randomness]");
+ credential.additionalData = params;
+
+ fetch("./resources/echo-post.php", { body: credential, method: "POST" }).then(
+ t.step_func(function (r) {
+ r.json().then(
+ t.step_func_done(function (j) {
+ assert_equals(j.username, 'id');
+ assert_equals(j.password, 'pencil');
+ assert_equals(j.excitingData, 'exciting value');
+ assert_equals(j.csrf, '[randomness]');
+ }),
+ t.unreached_func("Should be able to read the body."));
+ }),
+ t.unreached_func("Should not reject")
+ );
+}, "'additionalData': URLSearchParams properties are properly injected.");
philipj_slow 2015/11/17 15:53:59 Same question about order.
Mike West 2015/11/18 09:12:51 This will be simpler. :)
+</script>
« third_party/WebKit/LayoutTests/http/tests/credentialmanager/passwordcredential-basics.html ('K') | « third_party/WebKit/LayoutTests/http/tests/credentialmanager/passwordcredential-basics.html ('k') | third_party/WebKit/LayoutTests/http/tests/credentialmanager/resources/echo-post.php » ('j') | third_party/WebKit/Source/modules/credentialmanager/Credential.h » ('J')

Powered by Google App Engine