Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1440703003: Remove dependency on //components/bitmap_uploader on iOS. (Closed)

Created:
5 years, 1 month ago by sdefresne
Modified:
5 years, 1 month ago
Reviewers:
blundell
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dependency on //components/bitmap_uploader on iOS. //components/bitmap_uploader depends on //components/mus which in turn depends on //mojo which is not working on iOS (at least with gn build). BUG=459705 Committed: https://crrev.com/556ee5df7bca1796f9b6b67235ccd8ede8586f80 Cr-Commit-Position: refs/heads/master@{#359536}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (2 generated)
sdefresne
PTAL
5 years, 1 month ago (2015-11-13 10:05:43 UTC) #2
blundell
lgtm
5 years, 1 month ago (2015-11-13 10:12:48 UTC) #3
sdefresne
linux_rel_ng failures seems unrelated to CL, retrying the CQ.
5 years, 1 month ago (2015-11-13 11:38:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1440703003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1440703003/1
5 years, 1 month ago (2015-11-13 11:38:37 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-13 12:57:22 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 12:58:14 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/556ee5df7bca1796f9b6b67235ccd8ede8586f80
Cr-Commit-Position: refs/heads/master@{#359536}

Powered by Google App Engine
This is Rietveld 408576698