Clean up RenderLayer paintOrderLists code

Clean up RenderLayer paintOrderLists code

r149028 added a ton of code to RenderLayer that was more complex
than it needed to be. We should never use NodeLists from inside the
render tree, and there's also no reason to use a HashSet to store
RenderLayer related nodes as we can never see the same one twice.
The code was also passing around the size of Vectors which is silly,
Vectors have size()! :)

This patch simplifies the code a bunch to match best practice in
the render tree.

This patch also cleans up style guide violations such as missing
whitespace around keywords, an improperly indented switch, and
removes the default: clause from the switch statements that match
all cases as this is preferred since adding a new type for the switch
enum would cause compilation failure.

Another advantage of this patch is that paintOrderLists is the last
user of StaticHashSetNodeList. After this patch we can remove
this class.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149382

[Ian Vollick, 2013-04-26 13:28:16]

Looks great, thanks! I tested the patch out and confirmed that the opt-in layout
tests still pass. I had to make one small change to get things to compile.

https://codereview.chromium.org/14458008/diff/1/Source/core/rendering/RenderL...
File Source/core/rendering/RenderLayer.cpp (right):

https://codereview.chromium.org/14458008/diff/1/Source/core/rendering/RenderL...
Source/core/rendering/RenderLayer.cpp:736: void
RenderLayer::computePaintOrderList(PaintOrderListType type,
Vector<RefPtr<Node>>& list)
Need a space between angle braces here.

[Julien - ping for review, 2013-04-26 14:31:14]

You just proved that I have been too involved in the multiple iterations of this
patch to be a good reviewer at this point but I don't understand this:

"r149028 added a ton of code to RenderLayer that didn't follow the style guide"

AFAICT the code did follow the style guide and we have a presubmit check for
some of it. Could you point out what you thought were style violations?

[esprehn, 2013-04-26 22:52:43]

On 2013/04/26 14:31:14, Julien Chaffraix wrote:
> You just proved that I have been too involved in the multiple iterations of
this
> patch to be a good reviewer at this point but I don't understand this:
> 
> "r149028 added a ton of code to RenderLayer that didn't follow the style
guide"
> 
> AFAICT the code did follow the style guide and we have a presubmit check for
> some of it. Could you point out what you thought were style violations?

It was things like missing spaces around keywords, switch statements that were
indented wrong, adding default: clauses to switches that handle all cases. The
last one is more convention, I don't know how to get the style checker to catch
it since you need to know the enum values. I'm not sure why it didn't catch the
whitespace stuff the first time though.

[esprehn, 2013-04-28 09:27:11]

PTAL. It would be nice to land this so I can remove StaticHashSetNodeList. :)

[Julien - ping for review, 2013-04-29 20:28:34]

LGTM (thanks to Ian for testing the change).

[commit-bot: I haz the power, 2013-04-29 21:31:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/esprehn@chromium.org/14458008/8001

[commit-bot: I haz the power, 2013-04-29 23:16:37]

Change committed as 149382