Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: Source/core/testing/Internals.cpp

Issue 14458008: Clean up RenderLayer paintOrderLists code (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase and fix compile error Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderLayer.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2013 Apple Inc. All rights reserved. 3 * Copyright (C) 2013 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 1573 matching lines...) Expand 10 before | Expand all | Expand 10 after
1584 ec = INVALID_ACCESS_ERR; 1584 ec = INVALID_ACCESS_ERR;
1585 return 0; 1585 return 0;
1586 } 1586 }
1587 1587
1588 RenderLayer* layer = toRenderBox(renderer)->layer(); 1588 RenderLayer* layer = toRenderBox(renderer)->layer();
1589 if (!layer) { 1589 if (!layer) {
1590 ec = INVALID_ACCESS_ERR; 1590 ec = INVALID_ACCESS_ERR;
1591 return 0; 1591 return 0;
1592 } 1592 }
1593 1593
1594 return layer->paintOrderList(type); 1594 Vector<RefPtr<Node> > nodes;
1595 layer->computePaintOrderList(type, nodes);
1596 return StaticNodeList::adopt(nodes);
1595 } 1597 }
1596 1598
1597 PassRefPtr<NodeList> Internals::paintOrderListBeforePromote(Element* element, Ex ceptionCode& ec) 1599 PassRefPtr<NodeList> Internals::paintOrderListBeforePromote(Element* element, Ex ceptionCode& ec)
1598 { 1600 {
1599 return paintOrderList(element, ec, RenderLayer::BeforePromote); 1601 return paintOrderList(element, ec, RenderLayer::BeforePromote);
1600 } 1602 }
1601 1603
1602 PassRefPtr<NodeList> Internals::paintOrderListAfterPromote(Element* element, Exc eptionCode& ec) 1604 PassRefPtr<NodeList> Internals::paintOrderListAfterPromote(Element* element, Exc eptionCode& ec)
1603 { 1605 {
1604 return paintOrderList(element, ec, RenderLayer::AfterPromote); 1606 return paintOrderList(element, ec, RenderLayer::AfterPromote);
(...skipping 390 matching lines...) Expand 10 before | Expand all | Expand 10 after
1995 1997
1996 RenderObject* renderer = select->renderer(); 1998 RenderObject* renderer = select->renderer();
1997 if (!renderer->isMenuList()) 1999 if (!renderer->isMenuList())
1998 return false; 2000 return false;
1999 2001
2000 RenderMenuList* menuList = toRenderMenuList(renderer); 2002 RenderMenuList* menuList = toRenderMenuList(renderer);
2001 return menuList->popupIsVisible(); 2003 return menuList->popupIsVisible();
2002 } 2004 }
2003 2005
2004 } 2006 }
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderLayer.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698