Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1445623002: Add gn implementation of //ios/public/provider/chrome/browser. (Closed)

Created:
5 years, 1 month ago by sdefresne
Modified:
5 years, 1 month ago
Reviewers:
droger, Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@ios_web_shell
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add gn implementation of //ios/public/provider/chrome/browser. BUG=459705 Committed: https://crrev.com/32132f23cb43dbe5e7bfc299b16d24b7ae3a4c0c Cr-Commit-Position: refs/heads/master@{#360085}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -0 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/provider/ios_provider_chrome.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A ios/public/provider/chrome/browser/BUILD.gn View 1 chunk +35 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1443073002 Patch 1

Dependent Patchsets:

Issue 1441353003 Patch 1

Messages

Total messages: 8 (2 generated)
sdefresne
dpranke: can you review //BUILD.gn? droger: can you review //ios/public & //ios/provider?
5 years, 1 month ago (2015-11-13 17:27:55 UTC) #2
Dirk Pranke
lgtm
5 years, 1 month ago (2015-11-13 17:34:59 UTC) #3
droger
lgtm
5 years, 1 month ago (2015-11-17 12:06:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1445623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1445623002/1
5 years, 1 month ago (2015-11-17 15:45:03 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-17 16:22:30 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 16:23:57 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/32132f23cb43dbe5e7bfc299b16d24b7ae3a4c0c
Cr-Commit-Position: refs/heads/master@{#360085}

Powered by Google App Engine
This is Rietveld 408576698