Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 1441353003: Add //components/signin/ios/browser:unit_tests to components_unittests. (Closed)

Created:
5 years, 1 month ago by sdefresne
Modified:
5 years, 1 month ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@ios_provider_chrome
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add //components/signin/ios/browser:unit_tests to components_unittests. Fix an incorrect dependency in the BUILD.gn file and add deps to the targets in //components/BUILD.gn. Add a reference to gn target in //components/sessions.gypi. BUG=459705 Committed: https://crrev.com/06332e60d4928fee0cfa695cd55b3eab8f31a26a Cr-Commit-Position: refs/heads/master@{#360320}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M components/BUILD.gn View 1 6 chunks +4 lines, -2 lines 0 comments Download
M components/sessions.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/signin/ios/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
sdefresne
Please take a look.
5 years, 1 month ago (2015-11-13 17:38:06 UTC) #2
Dirk Pranke
lgtm
5 years, 1 month ago (2015-11-13 17:43:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1441353003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1441353003/1
5 years, 1 month ago (2015-11-17 16:24:19 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/95517) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 1 month ago (2015-11-17 16:27:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1441353003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1441353003/20001
5 years, 1 month ago (2015-11-18 09:45:54 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-18 10:54:05 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/06332e60d4928fee0cfa695cd55b3eab8f31a26a Cr-Commit-Position: refs/heads/master@{#360320}
5 years, 1 month ago (2015-11-18 10:55:11 UTC) #12
miu
5 years, 1 month ago (2015-11-19 02:50:47 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1458603009/ by miu@chromium.org.

The reason for reverting is: This patch set very likely broke all the
tab_capture_end2end_tests on Mac.

I am reverting this AND the change the sheriff made (which disabled the failing
tests): https://codereview.chromium.org/1456863003/

See http://crbug.com/557929 for more details..

Powered by Google App Engine
This is Rietveld 408576698