Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1443073002: Add gn implementation of //ios/web/shell:ios_web_shell. (Closed)

Created:
5 years, 1 month ago by sdefresne
Modified:
5 years, 1 month ago
Reviewers:
droger, Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@translate
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add gn implementation of //ios/web/shell:ios_web_shell. BUG=459705 Committed: https://crrev.com/8f676607eaaee80b54d9019ec6e37cdff3402e21 Cr-Commit-Position: refs/heads/master@{#360078}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -4 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A ios/web/app/BUILD.gn View 1 chunk +31 lines, -0 lines 0 comments Download
M ios/web/ios_web.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ios/web/ios_web_shell.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A + ios/web/public/app/BUILD.gn View 1 chunk +8 lines, -4 lines 0 comments Download
A ios/web/shell/BUILD.gn View 1 chunk +70 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1441923003 Patch 1

Dependent Patchsets:

Issue 1445623002 Patch 1

Messages

Total messages: 8 (2 generated)
sdefresne
dpranke: can you review //BUILD.gn? droger: can you review //ios/web?
5 years, 1 month ago (2015-11-13 17:24:28 UTC) #2
Dirk Pranke
lgtm
5 years, 1 month ago (2015-11-13 17:34:25 UTC) #3
droger
lgtm
5 years, 1 month ago (2015-11-17 13:30:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1443073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1443073002/1
5 years, 1 month ago (2015-11-17 14:52:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-17 15:43:38 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 15:44:24 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8f676607eaaee80b54d9019ec6e37cdff3402e21
Cr-Commit-Position: refs/heads/master@{#360078}

Powered by Google App Engine
This is Rietveld 408576698