Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1445543003: Add gn implementation for //components/keyed_service/ios. (Closed)

Created:
5 years, 1 month ago by sdefresne
Modified:
5 years, 1 month ago
Reviewers:
droger
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@dom_distiller
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add gn implementation for //components/keyed_service/ios. BUG=459705 Committed: https://crrev.com/1c70d414913c9bfab51417a6b0c2710aa7b81fa0 Cr-Commit-Position: refs/heads/master@{#360049}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
M components/BUILD.gn View 5 chunks +4 lines, -1 line 0 comments Download
M components/keyed_service.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A components/keyed_service/ios/BUILD.gn View 1 chunk +25 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1443713002 Patch 40001

Dependent Patchsets:

Issue 1437683008 Patch 20001

Messages

Total messages: 10 (5 generated)
sdefresne
Please take a look.
5 years, 1 month ago (2015-11-13 15:48:36 UTC) #2
droger
lgtm
5 years, 1 month ago (2015-11-13 16:09:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1445543003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1445543003/40001
5 years, 1 month ago (2015-11-17 09:15:14 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 1 month ago (2015-11-17 10:40:40 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 10:41:23 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1c70d414913c9bfab51417a6b0c2710aa7b81fa0
Cr-Commit-Position: refs/heads/master@{#360049}

Powered by Google App Engine
This is Rietveld 408576698