Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1443713002: Add gn implementation for //components/dom_distiller/ios. (Closed)

Created:
5 years, 1 month ago by sdefresne
Modified:
5 years, 1 month ago
Reviewers:
droger, blundell
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@ios_public_provider_web
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add gn implementation for //components/dom_distiller/ios. BUG=459705 Committed: https://crrev.com/7e9135eeea46525a166e5b0e9bfe332aada3fa6a Cr-Commit-Position: refs/heads/master@{#359901}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M components/BUILD.gn View 6 chunks +3 lines, -3 lines 2 comments Download
M components/dom_distiller.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A components/dom_distiller/ios/BUILD.gn View 1 chunk +18 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1442043002 Patch 20001

Dependent Patchsets:

Issue 1445543003 Patch 40001

Messages

Total messages: 13 (6 generated)
sdefresne
Please take a look.
5 years, 1 month ago (2015-11-13 15:45:24 UTC) #2
sdefresne
-blundell, +droger: PTAL
5 years, 1 month ago (2015-11-13 16:33:48 UTC) #4
blundell
lgtm https://codereview.chromium.org/1443713002/diff/40001/components/BUILD.gn File components/BUILD.gn (left): https://codereview.chromium.org/1443713002/diff/40001/components/BUILD.gn#oldcode59 components/BUILD.gn:59: "//components/enhanced_bookmarks", nit: fix these out-of-order entries while you're ...
5 years, 1 month ago (2015-11-16 08:22:08 UTC) #8
sdefresne
Thank you for the review. https://codereview.chromium.org/1443713002/diff/40001/components/BUILD.gn File components/BUILD.gn (left): https://codereview.chromium.org/1443713002/diff/40001/components/BUILD.gn#oldcode59 components/BUILD.gn:59: "//components/enhanced_bookmarks", On 2015/11/16 at ...
5 years, 1 month ago (2015-11-16 09:31:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1443713002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1443713002/40001
5 years, 1 month ago (2015-11-16 19:17:57 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 1 month ago (2015-11-16 20:37:52 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-16 20:38:44 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7e9135eeea46525a166e5b0e9bfe332aada3fa6a
Cr-Commit-Position: refs/heads/master@{#359901}

Powered by Google App Engine
This is Rietveld 408576698