Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1437683008: Add gn implementation for //components/history/ios/browser. (Closed)

Created:
5 years, 1 month ago by sdefresne
Modified:
5 years, 1 month ago
Reviewers:
droger
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@keyed_service
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add gn implementation for //components/history/ios/browser. BUG=459705 Committed: https://crrev.com/480a3d125be0e669351b49b17ec4bef4b2020214 Cr-Commit-Position: refs/heads/master@{#360063}

Patch Set 1 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M components/BUILD.gn View 5 chunks +6 lines, -5 lines 0 comments Download
M components/history.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A + components/history/ios/browser/BUILD.gn View 1 chunk +7 lines, -7 lines 0 comments Download

Depends on Patchset:

Issue 1445543003 Patch 40001

Dependent Patchsets:

Issue 1441923003 Patch 1

Messages

Total messages: 8 (3 generated)
sdefresne
Please take a look.
5 years, 1 month ago (2015-11-13 16:38:19 UTC) #3
droger
lgtm
5 years, 1 month ago (2015-11-13 16:58:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1437683008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1437683008/20001
5 years, 1 month ago (2015-11-17 11:07:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 1 month ago (2015-11-17 12:22:45 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 12:23:34 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/480a3d125be0e669351b49b17ec4bef4b2020214
Cr-Commit-Position: refs/heads/master@{#360063}

Powered by Google App Engine
This is Rietveld 408576698