Enabling Base Unit Tests

Enabling Base Unit Tests.

Updates mojo's Base enough to pass unit tests. Updating Mojo's
version of Base to be entirely consistent with Chromium would be
a significant ordeal, so this CL attempts to add passing Base
unit tests with as few changes to Base as possible.

Pulls in the following from Chromium:

3be75bf76ac061129ec2a9e887d5d50cfd016a56
Updates:
base/i18n/rtl_unittest.cc (Additional changes made manually to pass tests -- removed Windows-specific code).
base/test/icu_test_util.cc
base/test/icu_test_util.h

e89963accb5f3a9d93b8007b22fc79c0120eb794
Updates:
base/files/file_path_unittest.cc

R=viettrungluu@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/7a690c5c0344946ed74402d61d473502bc03ad77

[Sean Klein, 2015-11-16 19:32:23]

smklein@chromium.org changed reviewers:
+ viettrungluu@chromium.org

[viettrungluu, 2015-11-16 19:51:03]

Please update your CL description to indicate where you got
base/test/icu_test_util.h, etc. from (namely, the Chromium repo and appropriate
git hash).

https://codereview.chromium.org/1445163002/diff/20001/mojo/tools/get_test_lis...
File mojo/tools/get_test_list.py (right):

https://codereview.chromium.org/1445163002/diff/20001/mojo/tools/get_test_lis...
mojo/tools/get_test_list.py:85: [os.path.join(build_dir, "base_unittests")] +
verbose_flags)
Please just add this to the mojo/tools/data/unittests.

[Sean Klein, 2015-11-16 21:37:46]

Description was changed from

==========
Enabling Base Unit Tests
==========

to

==========
Enabling Base Unit Tests.

Updates mojo's Base enough to pass unit tests. Updating Mojo's
version of Base to be entirely consistent with Chromium would be
a significant ordeal, so this CL attempts to add passing Base
unit tests with as few changes to Base as possible.

Pulls in the following from Chromium:

3be75bf76ac061129ec2a9e887d5d50cfd016a56
Updates:
base/i18n/rtl_unittest.cc (Additional changes made manually to pass tests --
removed Windows-specific code).
base/test/icu_test_util.cc
base/test/icu_test_util.h

e89963accb5f3a9d93b8007b22fc79c0120eb794
Updates:
base/files/file_path_unittest.cc
==========

[Sean Klein, 2015-11-16 21:38:57]

https://codereview.chromium.org/1445163002/diff/20001/mojo/tools/get_test_lis...
File mojo/tools/get_test_list.py (right):

https://codereview.chromium.org/1445163002/diff/20001/mojo/tools/get_test_lis...
mojo/tools/get_test_list.py:85: [os.path.join(build_dir, "base_unittests")] +
verbose_flags)
On 2015/11/16 19:51:03, viettrungluu wrote:
> Please just add this to the mojo/tools/data/unittests.

Done.

[viettrungluu, 2015-11-17 22:27:32]

lgtm

[Sean Klein, 2015-11-17 22:34:31]

Committed patchset #3 (id:40001) manually as
7a690c5c0344946ed74402d61d473502bc03ad77 (presubmit successful).

[Sean Klein, 2015-11-18 16:54:14]

On 2015/11/17 22:34:31, smklein1 wrote:
> Committed patchset #3 (id:40001) manually as
> 7a690c5c0344946ed74402d61d473502bc03ad77 (presubmit successful).

This is causing an issue on the Debug Asan bots. Fix here:
https://codereview.chromium.org/1452063005/