Added SHA1HashFile unittests.

Added SHA1HashFile unittests.

A bit belated, but tests this CL:
https://codereview.chromium.org/1449693002/
Now that this CL has landed:
https://codereview.chromium.org/1445163002/

BUG=#396
R=phosek@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/a67383613f17083d918c31cf377932f5b43b91ab

[Sean Klein, 2015-11-17 22:00:14]

Description was changed from

==========
Added sha1 unittests.
==========

to

==========
Added SHA1HashFile unittests.
==========

[Sean Klein, 2015-11-17 22:28:41]

Patchset #1 (id:1) has been deleted

[Sean Klein, 2015-11-17 22:36:43]

smklein@chromium.org changed reviewers:
+ phosek@chromium.org

[Sean Klein, 2015-11-23 16:49:48]

Description was changed from

==========
Added SHA1HashFile unittests.
==========

to

==========
Added SHA1HashFile unittests.

A bit belated, but tests this CL:
https://codereview.chromium.org/1449693002/
Now that this CL has landed:
https://codereview.chromium.org/1445163002/

BUG=#396
==========

[Sean Klein, 2015-11-23 16:49:48]

smklein@chromium.org changed reviewers:
+ mseaborn@chromium.org
- phosek@chromium.org

[Sean Klein, 2015-12-01 23:08:24]

smklein@chromium.org changed reviewers:
+ phosek@chromium.org

[Mark Seaborn, 2015-12-02 22:33:14]

Can Petr or vtl review this, since they reviewed the change that this is a
follow-up to?

[Petr Hosek, 2015-12-02 22:51:32]

https://codereview.chromium.org/1460513002/diff/20001/base/sha1_unittest.cc
File base/sha1_unittest.cc (right):

https://codereview.chromium.org/1460513002/diff/20001/base/sha1_unittest.cc#n...
base/sha1_unittest.cc:112: void doHashFile(const std::string& input, unsigned
char *output) {
Nit: * belongs to type.

https://codereview.chromium.org/1460513002/diff/20001/base/sha1_unittest.cc#n...
base/sha1_unittest.cc:117: fwrite(input.c_str(), 1, input.length(),
file.get()));
Nit: I'd use sizeof(char) instead of 1.

https://codereview.chromium.org/1460513002/diff/20001/base/sha1_unittest.cc#n...
base/sha1_unittest.cc:128: unsigned char expected[] = { 0xa9, 0x99, 0x3e, 0x36,
This should be const.

https://codereview.chromium.org/1460513002/diff/20001/base/sha1_unittest.cc#n...
base/sha1_unittest.cc:145: unsigned char expected[] = { 0x84, 0x98, 0x3e, 0x44,
ditto

https://codereview.chromium.org/1460513002/diff/20001/base/sha1_unittest.cc#n...
base/sha1_unittest.cc:161: unsigned char expected[] = { 0x34, 0xaa, 0x97, 0x3c,
ditto

[Sean Klein, 2015-12-02 23:01:22]

https://codereview.chromium.org/1460513002/diff/20001/base/sha1_unittest.cc
File base/sha1_unittest.cc (right):

https://codereview.chromium.org/1460513002/diff/20001/base/sha1_unittest.cc#n...
base/sha1_unittest.cc:112: void doHashFile(const std::string& input, unsigned
char *output) {
On 2015/12/02 22:51:31, Petr Hosek wrote:
> Nit: * belongs to type.

Done.

https://codereview.chromium.org/1460513002/diff/20001/base/sha1_unittest.cc#n...
base/sha1_unittest.cc:117: fwrite(input.c_str(), 1, input.length(),
file.get()));
On 2015/12/02 22:51:31, Petr Hosek wrote:
> Nit: I'd use sizeof(char) instead of 1.

Done.

https://codereview.chromium.org/1460513002/diff/20001/base/sha1_unittest.cc#n...
base/sha1_unittest.cc:128: unsigned char expected[] = { 0xa9, 0x99, 0x3e, 0x36,
On 2015/12/02 22:51:31, Petr Hosek wrote:
> This should be const.

Done.

https://codereview.chromium.org/1460513002/diff/20001/base/sha1_unittest.cc#n...
base/sha1_unittest.cc:145: unsigned char expected[] = { 0x84, 0x98, 0x3e, 0x44,
On 2015/12/02 22:51:31, Petr Hosek wrote:
> ditto

Done.

https://codereview.chromium.org/1460513002/diff/20001/base/sha1_unittest.cc#n...
base/sha1_unittest.cc:161: unsigned char expected[] = { 0x34, 0xaa, 0x97, 0x3c,
On 2015/12/02 22:51:32, Petr Hosek wrote:
> ditto

Done.

[Petr Hosek, 2015-12-02 23:10:20]

lgtm

[Sean Klein, 2015-12-02 23:11:43]

Description was changed from

==========
Added SHA1HashFile unittests.

A bit belated, but tests this CL:
https://codereview.chromium.org/1449693002/
Now that this CL has landed:
https://codereview.chromium.org/1445163002/

BUG=#396
==========

to

==========
Added SHA1HashFile unittests.

A bit belated, but tests this CL:
https://codereview.chromium.org/1449693002/
Now that this CL has landed:
https://codereview.chromium.org/1445163002/

BUG=#396
R=phosek@chromium.org

Committed:
https://chromium.googlesource.com/external/mojo/+/a67383613f17083d918c31cf377...
==========

[Sean Klein, 2015-12-02 23:11:43]

Committed patchset #2 (id:40001) manually as
a67383613f17083d918c31cf377932f5b43b91ab (presubmit successful).