Enabling Base Unit Tests

base/i18n/rtl_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/i18n/rtl.h"
 
 #include <algorithm>
 
 #include "base/files/file_path.h"
 #include "base/strings/string_util.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
+#include "base/test/icu_test_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "testing/platform_test.h"
 #include "third_party/icu/source/i18n/unicode/usearch.h"
 
 namespace base {
 namespace i18n {
 
 namespace {
 
 // A test utility function to set the application default text direction.
@@ skipping 213 matching lines @@
       LEFT_TO_RIGHT },
    };
 
   for (size_t i = 0; i < arraysize(cases); ++i)
     EXPECT_EQ(cases[i].direction,
               GetStringDirection(WideToUTF16(cases[i].text)));
 }
 
 TEST_F(RTLTest, WrapPathWithLTRFormatting) {
   const wchar_t* cases[] = {
-    // Test common path, such as "c:\foo\bar".
-    L"c:/foo/bar",
-    // Test path with file name, such as "c:\foo\bar\test.jpg".
-    L"c:/foo/bar/test.jpg",
-    // Test path ending with punctuation, such as "c:\(foo)\bar.".
-    L"c:/(foo)/bar.",
-    // Test path ending with separator, such as "c:\foo\bar\".
-    L"c:/foo/bar/",
-    // Test path with RTL character.
-    L"c:/\x05d0",
-    // Test path with 2 level RTL directory names.
-    L"c:/\x05d0/\x0622",
-    // Test path with mixed RTL/LTR directory names and ending with punctuation.
-    L"c:/\x05d0/\x0622/(foo)/b.a.r.",
-    // Test path without driver name, such as "/foo/bar/test/jpg".
     L"/foo/bar/test.jpg",
     // Test path start with current directory, such as "./foo".
     L"./foo",
     // Test path start with parent directory, such as "../foo/bar.jpg".
     L"../foo/bar.jpg",
     // Test absolute path, such as "//foo/bar.jpg".
     L"//foo/bar.jpg",
-    // Test path with mixed RTL/LTR directory names.
-    L"c:/foo/\x05d0/\x0622/\x05d1.jpg",
     // Test empty path.
     L""
   };
 
   for (size_t i = 0; i < arraysize(cases); ++i) {
     FilePath path;
-#if defined(OS_WIN)
-    std::wstring win_path(cases[i]);
-    std::replace(win_path.begin(), win_path.end(), '/', '\\');
-    path = FilePath(win_path);
-    std::wstring wrapped_expected =
-        std::wstring(L"\x202a") + win_path + L"\x202c";
-#else
     path = FilePath(base::SysWideToNativeMB(cases[i]));
     std::wstring wrapped_expected =
         std::wstring(L"\x202a") + cases[i] + L"\x202c";
-#endif
     string16 localized_file_path_string;
     WrapPathWithLTRFormatting(path, &localized_file_path_string);
 
     std::wstring wrapped_actual = UTF16ToWide(localized_file_path_string);
     EXPECT_EQ(wrapped_expected, wrapped_actual);
   }
 }
 
 TEST_F(RTLTest, WrapString) {
   const wchar_t* cases[] = {
     L" . ",
     L"abc",
     L"a" L"\x5d0\x5d1",
     L"a" L"\x5d1" L"b",
     L"\x5d0\x5d1\x5d2",
     L"\x5d0\x5d1" L"a",
     L"\x5d0" L"a" L"\x5d1",
   };
 
   const bool was_rtl = IsRTL();
 
+  test::ScopedRestoreICUDefaultLocale restore_locale;
   for (size_t i = 0; i < 2; ++i) {
     // Toggle the application default text direction (to try each direction).
     SetRTL(!IsRTL());
 
     string16 empty;
     WrapStringWithLTRFormatting(&empty);
     EXPECT_TRUE(empty.empty());
     WrapStringWithRTLFormatting(&empty);
     EXPECT_TRUE(empty.empty());
 
@@ skipping 27 matching lines @@
     { L"\x05d0\x05d1\x05d2",     true,  true },
     { L"\x05d0\x05d1\x05d2.txt", true,  true },
     { L"\x05d0" L"abc",          true,  true },
     { L"\x05d0" L"abc.txt",      true,  true },
     { L"abc\x05d0\x05d1",        false, true },
     { L"abc\x05d0\x05d1.jpg",    false, true },
   };
 
   const bool was_rtl = IsRTL();
 
+  test::ScopedRestoreICUDefaultLocale restore_locale;
   for (size_t i = 0; i < 2; ++i) {
     // Toggle the application default text direction (to try each direction).
     SetRTL(!IsRTL());
     for (size_t i = 0; i < arraysize(cases); ++i) {
       string16 input = WideToUTF16(cases[i].path);
       string16 output = GetDisplayStringInLTRDirectionality(input);
       // Test the expected wrapping behavior for the current UI directionality.
       if (IsRTL() ? cases[i].wrap_rtl : cases[i].wrap_ltr)
         EXPECT_NE(output, input);
       else
@@ skipping 44 matching lines @@
     L",\x05d0 foo bar",
     L"\x202a \x05d0 foo  bar",
     L"\x202d \x05d0 foo  bar",
     L"\x202b foo \x05d0 bar",
     L"\x202e foo \x05d0 bar",
     L"\x0622 foo \x05d0 bar",
   };
 
   const bool was_rtl = IsRTL();
 
+  test::ScopedRestoreICUDefaultLocale restore_locale;
   for (size_t i = 0; i < 2; ++i) {
     // Toggle the application default text direction (to try each direction).
     SetRTL(!IsRTL());
 
     for (size_t i = 0; i < arraysize(cases); ++i) {
       string16 test_case = WideToUTF16(cases[i]);
       string16 adjusted_string = test_case;
 
       if (!AdjustStringForLocaleDirection(&adjusted_string))
         continue;
 
       EXPECT_NE(test_case, adjusted_string);
       EXPECT_TRUE(UnadjustStringForLocaleDirection(&adjusted_string));
       EXPECT_EQ(test_case, adjusted_string) << " for test case [" << test_case
                                             << "] with IsRTL() == " << IsRTL();
     }
   }
 
   EXPECT_EQ(was_rtl, IsRTL());
 }
 
 }  // namespace i18n
 }  // namespace base