Issue 1444473003: Make visualbench timing continuous for no-reset mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1444473003: Make visualbench timing continuous for no-reset mode (Closed)

Created:
5 years, 1 month ago by Chris Dalton

Modified:
5 years, 1 month ago

Reviewers:
joshualitt

CC:
reviews_skia.org, nv_mark, Kimmo Kinnunen

Base URL:
https://skia.googlesource.com/skia.git@upload_no_reset

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Make visualbench timing continuous for no-reset mode Ensures there is no period of time that is not on the clock when not restting the graphics context between samples. BUG=skia: Committed: https://skia.googlesource.com/skia/+/1023725bb6a774fddb5b601a5cd6ab3af3e9996f

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -21 lines)			Patch
	M	tools/VisualBench/TimingStateMachine.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
	M	tools/VisualBench/TimingStateMachine.cpp	View		2 chunks	+6 lines, -17 lines	0 comments	Download

Depends on Patchset:

Issue 1442643007 Patch 1

Dependent Patchsets:

Issue 1441073005 Patch 1

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1444473003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1444473003/1

5 years, 1 month ago (2015-11-13 16:30:23 UTC) #5

commit-bot: I haz the power

5 years, 1 month ago (2015-11-13 16:42:09 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1023725bb6a774fddb5b601a5cd6ab3af3e9996f

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages