Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issue 1442643007: Add visualbench option to not reset between samples (Closed)

Created:
5 years, 1 month ago by Chris Dalton
Modified:
5 years, 1 month ago
Reviewers:
joshualitt
CC:
reviews_skia.org, nv_mark, Kimmo Kinnunen
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add visualbench option to not reset between samples Adds a --reset flag that controls whether we teardown the graphics context between samples. Also modifies the timing algorithm to always/ only pre-warm after resetting the context. BUG=skia: Committed: https://skia.googlesource.com/skia/+/266e2024ec487425f56473e272a6b81bfbf2c543

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -15 lines) Patch
M tools/VisualBench/VisualInteractiveModule.cpp View 1 chunk +1 line, -1 line 1 comment Download
M tools/VisualBench/VisualLightweightBenchModule.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/VisualBench/VisualStreamTimingModule.h View 2 chunks +1 line, -2 lines 0 comments Download
M tools/VisualBench/VisualStreamTimingModule.cpp View 4 chunks +13 lines, -11 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 6 (2 generated)
Chris Dalton
https://codereview.chromium.org/1442643007/diff/1/tools/VisualBench/VisualInteractiveModule.cpp File tools/VisualBench/VisualInteractiveModule.cpp (left): https://codereview.chromium.org/1442643007/diff/1/tools/VisualBench/VisualInteractiveModule.cpp#oldcode18 tools/VisualBench/VisualInteractiveModule.cpp:18: : INHERITED(owner, false) This is the only change in ...
5 years, 1 month ago (2015-11-13 07:45:01 UTC) #2
joshualitt
On 2015/11/13 07:45:01, Chris Dalton wrote: > https://codereview.chromium.org/1442643007/diff/1/tools/VisualBench/VisualInteractiveModule.cpp > File tools/VisualBench/VisualInteractiveModule.cpp (left): > > https://codereview.chromium.org/1442643007/diff/1/tools/VisualBench/VisualInteractiveModule.cpp#oldcode18 ...
5 years, 1 month ago (2015-11-13 16:07:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1442643007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1442643007/1
5 years, 1 month ago (2015-11-13 16:12:43 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 16:28:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/266e2024ec487425f56473e272a6b81bfbf2c543

Powered by Google App Engine
This is Rietveld 408576698