WebGeolocationController: improve handling of bare GeolocationController*

WebGeolocationController: improve handling of bare GeolocationController*

While GeolocationController is still being transitioned to Oilpan,
introduce an intermediary abstraction that allows WebGeolocationController
to keep a WebPrivatePtr<>. Thereby letting us correctly trace the
GeolocationController it wraps.

R=haraken,tkent
BUG=553613
Committed: https://crrev.com/f71025b97e1fb8867170e57952db6e2359d78fa9
Cr-Commit-Position: refs/heads/master@{#360027}

[sof, 2015-11-16 14:24:53]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org, tkent@chromium.org

[sof, 2015-11-16 14:24:54]

please take a look.

Somewhat quirky, but avoids keeping a bare heap reference.

[sof, 2015-11-16 14:25:46]

Description was changed from

==========
WebGeolocationController: improve handling of bare GeolocationController*

While GeolocationController is still being transitioned to Oilpane,
introduce an intermediary abstraction that allows WebGeolocationController
to keep a WebPrivatePtr<>. Thereby letting us correctly trace the
GeolocationController it wraps.

R=
BUG=553613
==========

to

==========
WebGeolocationController: improve handling of bare GeolocationController*

While GeolocationController is still being transitioned to Oilpan,
introduce an intermediary abstraction that allows WebGeolocationController
to keep a WebPrivatePtr<>. Thereby letting us correctly trace the
GeolocationController it wraps.

R=
BUG=553613
==========

[haraken, 2015-11-16 15:01:51]

On 2015/11/16 14:24:54, sof wrote:
> please take a look.
> 
> Somewhat quirky, but avoids keeping a bare heap reference.

Would you help me understand why using WebPrivatePtr<GeolocationController>
doesn't work?

If it is just because the current WebPrivatePtr supports only RefPtr and
Persistent (i.e., doesn't support OwnPtr), would there be an option to change
GeolocationController RefCounted in non-oilpan?

[sof, 2015-11-16 15:06:05]

On 2015/11/16 15:01:51, haraken wrote:
> On 2015/11/16 14:24:54, sof wrote:
> > please take a look.
> > 
> > Somewhat quirky, but avoids keeping a bare heap reference.
> 
> Would you help me understand why using WebPrivatePtr<GeolocationController>
> doesn't work?
> 
> If it is just because the current WebPrivatePtr supports only RefPtr and
> Persistent (i.e., doesn't support OwnPtr), would there be an option to change
> GeolocationController RefCounted in non-oilpan?

GeolocationController is a supplement, hence Own(Ptr)ed by the supplementable.

[haraken, 2015-11-16 15:10:50]

On 2015/11/16 15:06:05, sof wrote:
> On 2015/11/16 15:01:51, haraken wrote:
> > On 2015/11/16 14:24:54, sof wrote:
> > > please take a look.
> > > 
> > > Somewhat quirky, but avoids keeping a bare heap reference.
> > 
> > Would you help me understand why using WebPrivatePtr<GeolocationController>
> > doesn't work?
> > 
> > If it is just because the current WebPrivatePtr supports only RefPtr and
> > Persistent (i.e., doesn't support OwnPtr), would there be an option to
change
> > GeolocationController RefCounted in non-oilpan?
> 
> GeolocationController is a supplement, hence Own(Ptr)ed by the supplementable.

ah, makes sense. Using RefCountedSupplement would be more nasty.

LGTM

[sof, 2015-11-16 15:14:19]

On 2015/11/16 15:10:50, haraken wrote:
> On 2015/11/16 15:06:05, sof wrote:
> > On 2015/11/16 15:01:51, haraken wrote:
> > > On 2015/11/16 14:24:54, sof wrote:
> > > > please take a look.
> > > > 
> > > > Somewhat quirky, but avoids keeping a bare heap reference.
> > > 
> > > Would you help me understand why using
WebPrivatePtr<GeolocationController>
> > > doesn't work?
> > > 
> > > If it is just because the current WebPrivatePtr supports only RefPtr and
> > > Persistent (i.e., doesn't support OwnPtr), would there be an option to
> change
> > > GeolocationController RefCounted in non-oilpan?
> > 
> > GeolocationController is a supplement, hence Own(Ptr)ed by the
supplementable.
> 
> ah, makes sense. Using RefCountedSupplement would be more nasty.
> 
> LGTM

We can simplify this away soon enough, I hope.

[tkent, 2015-11-16 23:49:31]

tkent@chromium.org changed reviewers:
+ haraken@chromium.org

[tkent, 2015-11-16 23:49:31]

lgtm

[sof, 2015-11-17 06:16:36]

Description was changed from

==========
WebGeolocationController: improve handling of bare GeolocationController*

While GeolocationController is still being transitioned to Oilpan,
introduce an intermediary abstraction that allows WebGeolocationController
to keep a WebPrivatePtr<>. Thereby letting us correctly trace the
GeolocationController it wraps.

R=
BUG=553613
==========

to

==========
WebGeolocationController: improve handling of bare GeolocationController*

While GeolocationController is still being transitioned to Oilpan,
introduce an intermediary abstraction that allows WebGeolocationController
to keep a WebPrivatePtr<>. Thereby letting us correctly trace the
GeolocationController it wraps.

R=haraken,tkent
BUG=553613
==========

[sof, 2015-11-17 06:16:40]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2015-11-17 06:17:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1444333002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1444333002/1

[commit-bot: I haz the power, 2015-11-17 06:59:03]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-11-17 07:00:09]

Patchset 1 (id:??) landed as
https://crrev.com/f71025b97e1fb8867170e57952db6e2359d78fa9
Cr-Commit-Position: refs/heads/master@{#360027}