third_party/WebKit/Source/modules/geolocation/GeolocationController.h - Issue 1444333002: WebGeolocationController: improve handling of bare GeolocationController*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/geolocation/GeolocationController.h

Issue 1444333002: WebGeolocationController: improve handling of bare GeolocationController* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/geolocation/GeolocationController.h

diff --git a/third_party/WebKit/Source/modules/geolocation/GeolocationController.h b/third_party/WebKit/Source/modules/geolocation/GeolocationController.h

index 01a0effc120d5f569e8f2939ce0635bcbb934c70..6b6f2a0d83d64d1e6ef57819e431edbb2485a4b6 100644

--- a/third_party/WebKit/Source/modules/geolocation/GeolocationController.h

+++ b/third_party/WebKit/Source/modules/geolocation/GeolocationController.h

@@ -40,7 +40,7 @@ class GeolocationClient;

class GeolocationError;

class GeolocationPosition;

-class MODULES_EXPORT GeolocationController final : public NoBaseWillBeGarbageCollectedFinalized<GeolocationController>, public WillBeHeapSupplement<LocalFrame>, public PageLifecycleObserver {

+class MODULES_EXPORT GeolocationController : public NoBaseWillBeGarbageCollectedFinalized<GeolocationController>, public WillBeHeapSupplement<LocalFrame>, public PageLifecycleObserver {

WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(GeolocationController);

WTF_MAKE_NONCOPYABLE(GeolocationController);

USING_FAST_MALLOC_WILL_BE_REMOVED(GeolocationController);

« no previous file with comments | « no previous file | third_party/WebKit/Source/web/WebGeolocationController.cpp » ('j') | no next file with comments »