Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: third_party/WebKit/Source/modules/geolocation/GeolocationController.h

Issue 1444333002: WebGeolocationController: improve handling of bare GeolocationController* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/WebGeolocationController.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2009 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 22 matching lines...) Expand all
33 #include "platform/heap/Handle.h" 33 #include "platform/heap/Handle.h"
34 #include "wtf/HashSet.h" 34 #include "wtf/HashSet.h"
35 #include "wtf/Noncopyable.h" 35 #include "wtf/Noncopyable.h"
36 36
37 namespace blink { 37 namespace blink {
38 38
39 class GeolocationClient; 39 class GeolocationClient;
40 class GeolocationError; 40 class GeolocationError;
41 class GeolocationPosition; 41 class GeolocationPosition;
42 42
43 class MODULES_EXPORT GeolocationController final : public NoBaseWillBeGarbageCol lectedFinalized<GeolocationController>, public WillBeHeapSupplement<LocalFrame>, public PageLifecycleObserver { 43 class MODULES_EXPORT GeolocationController : public NoBaseWillBeGarbageCollected Finalized<GeolocationController>, public WillBeHeapSupplement<LocalFrame>, publi c PageLifecycleObserver {
44 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(GeolocationController); 44 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(GeolocationController);
45 WTF_MAKE_NONCOPYABLE(GeolocationController); 45 WTF_MAKE_NONCOPYABLE(GeolocationController);
46 USING_FAST_MALLOC_WILL_BE_REMOVED(GeolocationController); 46 USING_FAST_MALLOC_WILL_BE_REMOVED(GeolocationController);
47 public: 47 public:
48 virtual ~GeolocationController(); 48 virtual ~GeolocationController();
49 49
50 static PassOwnPtrWillBeRawPtr<GeolocationController> create(LocalFrame&, Geo locationClient*); 50 static PassOwnPtrWillBeRawPtr<GeolocationController> create(LocalFrame&, Geo locationClient*);
51 51
52 void addObserver(Geolocation*, bool enableHighAccuracy); 52 void addObserver(Geolocation*, bool enableHighAccuracy);
53 void removeObserver(Geolocation*); 53 void removeObserver(Geolocation*);
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 typedef PersistentHeapHashSetWillBeHeapHashSet<Member<Geolocation>> Observer sSet; 86 typedef PersistentHeapHashSetWillBeHeapHashSet<Member<Geolocation>> Observer sSet;
87 // All observers; both those requesting high accuracy and those not. 87 // All observers; both those requesting high accuracy and those not.
88 ObserversSet m_observers; 88 ObserversSet m_observers;
89 ObserversSet m_highAccuracyObservers; 89 ObserversSet m_highAccuracyObservers;
90 bool m_isClientUpdating; 90 bool m_isClientUpdating;
91 }; 91 };
92 92
93 } // namespace blink 93 } // namespace blink
94 94
95 #endif // GeolocationController_h 95 #endif // GeolocationController_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/WebGeolocationController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698