Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 144413002: Fix xvfb for blink trybot. (Closed)

Created:
6 years, 11 months ago by iannucci
Modified:
6 years, 11 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, stip+watch_chromium.org, cmp-cc_chromium.org, ilevy-cc_chromium.org, kjellander+cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -38 lines) Patch
M scripts/slave/recipes/blink_trybot.py View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/linux_passFirst_debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/linux_passFirst_debug_git.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/linux_passFirst_release.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/linux_passFirst_release_git.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/linux_passMinimal_debug.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/linux_passMinimal_debug_git.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/linux_passMinimal_release.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/linux_passMinimal_release_git.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/mac_passFirst_debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/mac_passFirst_debug_git.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/mac_passFirst_release.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/mac_passFirst_release_git.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/mac_passMinimal_debug.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/mac_passMinimal_debug_git.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/mac_passMinimal_release.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/mac_passMinimal_release_git.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/minimal_pass_continues.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/win_passFirst_debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/win_passFirst_debug_git.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/win_passFirst_release.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/win_passFirst_release_git.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/win_passMinimal_debug.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/win_passMinimal_debug_git.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/win_passMinimal_release.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/win_passMinimal_release_git.json View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
iannucci
6 years, 11 months ago (2014-01-21 23:54:32 UTC) #1
Dirk Pranke
lgtm, though it's a bit odd that we'd pass the xvfb flag on mac and ...
6 years, 11 months ago (2014-01-21 23:58:13 UTC) #2
iannucci
On 2014/01/21 23:58:13, Dirk Pranke wrote: > lgtm, though it's a bit odd that we'd ...
6 years, 11 months ago (2014-01-21 23:59:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/144413002/1
6 years, 11 months ago (2014-01-22 00:00:12 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-22 00:01:34 UTC) #5
Message was sent while issue was closed. 
Change committed as 246175

Powered by Google App Engine
This is Rietveld 408576698