scripts/slave/recipes/blink_trybot.expected/win_passFirst_release_git.json - Issue 144413002: Fix xvfb for blink trybot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/blink_trybot.expected/win_passFirst_release_git.json

Issue 144413002: Fix xvfb for blink trybot. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/blink_trybot.expected/win_passFirst_release.json ('k') | scripts/slave/recipes/blink_trybot.expected/win_passMinimal_debug.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/blink_trybot.expected/win_passFirst_release_git.json

diff --git a/scripts/slave/recipes/blink_trybot.expected/win_passFirst_release_git.json b/scripts/slave/recipes/blink_trybot.expected/win_passFirst_release_git.json

index 5547fd319c5dffcd0b489ee78fff83232a43dec8..604e8d4edc936379ed9c6436d376089545a536b2 100644

--- a/scripts/slave/recipes/blink_trybot.expected/win_passFirst_release_git.json

+++ b/scripts/slave/recipes/blink_trybot.expected/win_passFirst_release_git.json

@@ -269,7 +269,7 @@

"Release",

"--build-dir",

"[SLAVE_BUILD]\\src\\out",

- "--no-xvfb",

+ "--xvfb",

"--factory-properties",

"{\"GIT_MODE\": true, \"blamelist\": [\"cool_dev1337@chromium.org\", \"hax@chromium.org\"], \"branch\": \"\", \"build_config\": \"Release\", \"buildername\": \"TestBuilder\", \"buildnumber\": 571, \"config_name\": \"blink\", \"issue\": 12853011, \"mastername\": \"chromium.testing.master\", \"patchset\": 1, \"project\": \"chrome\", \"recipe\": \"blink_trybot\", \"repository\": \"\", \"requester\": \"commit-bot@chromium.org\", \"revision\": \"HEAD\", \"rietveld\": \"https://codereview.chromium.org\", \"root\": \"src/third_party/WebKit\", \"slavename\": \"TestSlavename\", \"workdir\": \"/path/to/workdir/TestSlavename\"}",

"--build-properties",