Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: scripts/slave/recipes/blink_trybot.expected/win_passMinimal_release_git.json

Issue 144413002: Fix xvfb for blink trybot. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « scripts/slave/recipes/blink_trybot.expected/win_passMinimal_release.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipes/blink_trybot.expected/win_passMinimal_release_git.json
diff --git a/scripts/slave/recipes/blink_trybot.expected/win_passMinimal_release_git.json b/scripts/slave/recipes/blink_trybot.expected/win_passMinimal_release_git.json
index 1a8fbe7a9e6e92f0b2c5267e0d6009abfea1b9a4..70617b49c9542e517705b333ed75230debcc83fc 100644
--- a/scripts/slave/recipes/blink_trybot.expected/win_passMinimal_release_git.json
+++ b/scripts/slave/recipes/blink_trybot.expected/win_passMinimal_release_git.json
@@ -269,7 +269,7 @@
"Release",
"--build-dir",
"[SLAVE_BUILD]\\src\\out",
- "--no-xvfb",
+ "--xvfb",
"--factory-properties",
"{\"GIT_MODE\": true, \"blamelist\": [\"cool_dev1337@chromium.org\", \"hax@chromium.org\"], \"branch\": \"\", \"build_config\": \"Release\", \"buildername\": \"TestBuilder\", \"buildnumber\": 571, \"config_name\": \"blink\", \"issue\": 12853011, \"mastername\": \"chromium.testing.master\", \"patchset\": 1, \"project\": \"chrome\", \"recipe\": \"blink_trybot\", \"repository\": \"\", \"requester\": \"commit-bot@chromium.org\", \"revision\": \"HEAD\", \"rietveld\": \"https://codereview.chromium.org\", \"root\": \"src/third_party/WebKit\", \"slavename\": \"TestSlavename\", \"workdir\": \"/path/to/workdir/TestSlavename\"}",
"--build-properties",
@@ -413,7 +413,7 @@
"Release",
"--build-dir",
"[SLAVE_BUILD]\\src\\out",
- "--no-xvfb",
+ "--xvfb",
"--factory-properties",
"{\"GIT_MODE\": true, \"blamelist\": [\"cool_dev1337@chromium.org\", \"hax@chromium.org\"], \"branch\": \"\", \"build_config\": \"Release\", \"buildername\": \"TestBuilder\", \"buildnumber\": 571, \"config_name\": \"blink\", \"issue\": 12853011, \"mastername\": \"chromium.testing.master\", \"patchset\": 1, \"project\": \"chrome\", \"recipe\": \"blink_trybot\", \"repository\": \"\", \"requester\": \"commit-bot@chromium.org\", \"revision\": \"HEAD\", \"rietveld\": \"https://codereview.chromium.org\", \"root\": \"src/third_party/WebKit\", \"slavename\": \"TestSlavename\", \"workdir\": \"/path/to/workdir/TestSlavename\"}",
"--build-properties",
« no previous file with comments | « scripts/slave/recipes/blink_trybot.expected/win_passMinimal_release.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698