Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1442043002: Port //components/webp_transcode to build with gn. (Closed)

Created:
5 years, 1 month ago by sdefresne
Modified:
5 years, 1 month ago
Reviewers:
droger
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@password_manager
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Port //components/webp_transcode to build with gn. BUG=459705 Committed: https://crrev.com/f18cfc2c3317e25af0924a7f63dde5dc1e64001e Cr-Commit-Position: refs/heads/master@{#359859}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -2 lines) Patch
M components/BUILD.gn View 2 chunks +5 lines, -2 lines 0 comments Download
M components/webp_transcode.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A components/webp_transcode/BUILD.gn View 1 chunk +38 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (4 generated)
sdefresne
Please take a look.
5 years, 1 month ago (2015-11-13 15:33:35 UTC) #2
sdefresne
https://codereview.chromium.org/1442043002/diff/1/components/BUILD.gn File components/BUILD.gn (left): https://codereview.chromium.org/1442043002/diff/1/components/BUILD.gn#oldcode491 components/BUILD.gn:491: deps += [ "//components/sessions:unit_tests" ] Note that this was ...
5 years, 1 month ago (2015-11-13 15:34:50 UTC) #3
droger
lgtm
5 years, 1 month ago (2015-11-13 16:13:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1442043002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1442043002/20001
5 years, 1 month ago (2015-11-16 16:27:43 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 1 month ago (2015-11-16 17:38:13 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-16 17:39:50 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f18cfc2c3317e25af0924a7f63dde5dc1e64001e
Cr-Commit-Position: refs/heads/master@{#359859}

Powered by Google App Engine
This is Rietveld 408576698