Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issue 144363003: Revert of Revert of Move preferred scrollbar style preference change listening from renderer to browser, 3 of 3. (Closed)

Created:
6 years, 11 months ago by Robert Sesek
Modified:
6 years, 11 months ago
CC:
blink-reviews, jamesr, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dglazkov+blink, abarth-chromium, dstockwell, Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers, ccameron
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Revert of Revert of Move preferred scrollbar style preference change listening from renderer to browser, 3 of 3. (https://codereview.chromium.org/147193002/) Reason for revert: Fixed in Chromium with https://codereview.chromium.org/145013018 Original issue's description: > Revert of Move preferred scrollbar style preference change listening from renderer to browser, 3 of 3. (https://codereview.chromium.org/136333009/) > > Reason for revert: > This seems to be causing a mac_rel failure and is blocking blink roll. > > see here: http://build.chromium.org/p/tryserver.chromium/builders/mac_rel/builds/215993/steps/content_browsertests/logs/stdio > > > Original issue's description: > > Move preferred scrollbar style preference change listening from renderer to browser, 3 of 3. > > > > This removes the preferred style listener from Blink, now that the browser > > sends the value when it changes over IPC. > > > > BUG=306348 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165714 > > TBR=jamesr@chromium.org,thakis@chromium.org,rsesek@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=306348 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165774 TBR=jamesr@chromium.org,thakis@chromium.org,hclam@chromium.org NOTREECHECKS=true NOTRY=true BUG=306348 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165857

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -229 lines) Patch
M Source/platform/blink_platform.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/mac/NSScrollerImpDetails.h View 3 chunks +6 lines, -15 lines 0 comments Download
D Source/platform/mac/NSScrollerImpDetails.mm View 1 chunk +0 lines, -95 lines 0 comments Download
M Source/platform/mac/ScrollAnimatorMac.mm View 26 chunks +43 lines, -43 lines 0 comments Download
M Source/platform/scroll/ScrollbarThemeMacCommon.h View 3 chunks +6 lines, -1 line 0 comments Download
M Source/platform/scroll/ScrollbarThemeMacCommon.mm View 4 chunks +29 lines, -2 lines 0 comments Download
M Source/platform/scroll/ScrollbarThemeMacOverlayAPI.mm View 2 chunks +2 lines, -2 lines 0 comments Download
D Source/web/mac/WebScrollbarTheme.cpp View 1 chunk +0 lines, -65 lines 0 comments Download
A Source/web/mac/WebScrollbarTheme.mm View 1 chunk +58 lines, -0 lines 0 comments Download
M Source/web/web.gypi View 1 chunk +1 line, -1 line 0 comments Download
M public/web/mac/WebScrollbarTheme.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Robert Sesek
6 years, 11 months ago (2014-01-27 15:24:24 UTC) #1
Created Revert of Revert of Move preferred scrollbar style preference change
listening from renderer to browser, 3 of 3.

Powered by Google App Engine
This is Rietveld 408576698