Issue 144343006: Handle URLError timeout from Rietveld

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 144343006: Handle URLError timeout from Rietveld (Closed)

Created:
6 years, 11 months ago by Sergey Berezin

Modified:
6 years, 11 months ago

Reviewers:
Paweł Hajdan Jr.

CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/commit-queue

Visibility:
Public.

More Reviews

Description

Handle URLError timeout from Rietveld While communicating to Rietveld, urllib2 request timed out and raised URLError, which was not handled in try_job_on_rietveld._update_jobs_from_rietveld() and propagated to the top CQ loop causing a crash. This patch fixes it. BUG=337907 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=247376

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changes in response to comments #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	verification/try_job_on_rietveld.py	View	1	2 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

LGTM with minor comments. https://codereview.chromium.org/144343006/diff/1/verification/try_job_on_rietveld.py File verification/try_job_on_rietveld.py (right): https://codereview.chromium.org/144343006/diff/1/verification/try_job_on_rietveld.py#newcode732 verification/try_job_on_rietveld.py:732: except urllib2.URLError as e: Let's ...

6 years, 11 months ago (2014-01-28 01:26:29 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyberezin@chromium.org/144343006/20001

6 years, 11 months ago (2014-01-28 01:37:13 UTC) #3

Message was sent while issue was closed.

Change committed as 247376

Expand Messages | Collapse Messages