Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: verification/try_job_on_rietveld.py

Issue 144343006: Handle URLError timeout from Rietveld (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/commit-queue
Patch Set: Changes in response to comments Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: verification/try_job_on_rietveld.py
diff --git a/verification/try_job_on_rietveld.py b/verification/try_job_on_rietveld.py
index b932f8eeb0885a62fa91ea6c40b9dbb05e689d09..359acb6ae8bee76aff244310929d025c3c5d9576 100644
--- a/verification/try_job_on_rietveld.py
+++ b/verification/try_job_on_rietveld.py
@@ -720,6 +720,14 @@ class TryRunnerRietveld(base.VerifierCheckout):
return False
else:
raise
+ except urllib2.URLError as e:
+ if 'timed out' in e.reason:
+ # Handle timeouts gracefully.
+ logging.warning('%s while updating tryserver status for '
+ 'rietveld issue %s', e, pending.issue)
+ return False
+ else:
+ raise
except socket.error as e:
# Temporary AppEngine hiccup. Just log it and return failure.
if e.errno == errno.ECONNRESET:
@@ -737,6 +745,7 @@ class TryRunnerRietveld(base.VerifierCheckout):
str(e), str(pending.issue)))
return False
raise
+
if handle:
for updated_key in keys:
job = jobs.try_jobs[updated_key]
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698