Handle URLError timeout from Rietveld

verification/try_job_on_rietveld.py

 # coding=utf8
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 """Sends patches to the Try server and reads back results.
 
 - RietveldTryJobs contains RietveldTryJob, one per try job on a builder.
 - TryRunnerRietveld uses Rietveld to signal and poll job results.
 """
 
@@ skipping 711 matching lines @@
         raise
     except socket.error as e:
       # Temporary AppEngine hiccup. Just log it and return failure.
       if e.errno == errno.ECONNRESET:
         logging.warning(
             '%s while updating tryserver status for rietveld issue %s.' % (
             str(e), str(pending.issue)))
         return False
       else:
         raise
+    except urllib2.URLError as e:

[Paweł Hajdan Jr., 2014/01/28 01:26:29]

Let's just put it right below urllib2.HTTPError.

+      if 'timed out' in e.reason:
+        # Handle timeouts gracefully.
+        logging.warning('%s while updating tryserver status for '
+                        +'rietveld issue %s', e, pending.issue)

[Paweł Hajdan Jr., 2014/01/28 01:26:29]

nit: Add space after +. Actually the + should not be needed.

+        return False
+      else:
+        raise
     except IOError as e:
       # Temporary AppEngine hiccup. Just log it and return failure.
       if e.errno == 'socket error':
         logging.warning(
             '%s while updating tryserver status for rietveld issue %s.' % (
             str(e), str(pending.issue)))
         return False
       raise
+
     if handle:
       for updated_key in keys:
         job = jobs.try_jobs[updated_key]
         self._update_dashboard(pending, job)
         jobs.signal_as_failed_if_needed(job, self._build_status_url(job), now)
 
     return True