Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1441923003: Add gn implementation for //components/translate/ios/browser. (Closed)

Created:
5 years, 1 month ago by sdefresne
Modified:
5 years, 1 month ago
Reviewers:
droger
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@history
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add gn implementation for //components/translate/ios/browser. BUG=459705, 523060 Committed: https://crrev.com/90d2c80a6ac547c5a9017e3870b21c69f4285557 Cr-Commit-Position: refs/heads/master@{#360072}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -7 lines) Patch
M components/BUILD.gn View 6 chunks +10 lines, -6 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M components/translate.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
A components/translate/ios/browser/BUILD.gn View 1 chunk +59 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1437683008 Patch 20001

Dependent Patchsets:

Issue 1443073002 Patch 1

Messages

Total messages: 7 (2 generated)
sdefresne
Please take a look.
5 years, 1 month ago (2015-11-13 16:49:33 UTC) #2
droger
lgtm
5 years, 1 month ago (2015-11-13 16:52:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1441923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1441923003/1
5 years, 1 month ago (2015-11-17 13:42:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-17 14:48:46 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 14:49:38 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/90d2c80a6ac547c5a9017e3870b21c69f4285557
Cr-Commit-Position: refs/heads/master@{#360072}

Powered by Google App Engine
This is Rietveld 408576698