Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2147)

Unified Diff: chrome/browser/local_discovery/privet_http_asynchronous_factory_impl.h

Issue 1442923002: Extract resolution logic from PrivetHTTPAsynchronousFactory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@1436373002
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/local_discovery/privet_http_asynchronous_factory_impl.h
diff --git a/chrome/browser/local_discovery/privet_http_asynchronous_factory_impl.h b/chrome/browser/local_discovery/privet_http_asynchronous_factory_impl.h
index bc5448f5e354166657f7dd93c7a10d8386f15944..8681a27f071589602decb1fa2f3c248c24cc131d 100644
--- a/chrome/browser/local_discovery/privet_http_asynchronous_factory_impl.h
+++ b/chrome/browser/local_discovery/privet_http_asynchronous_factory_impl.h
@@ -5,13 +5,13 @@
#ifndef CHROME_BROWSER_LOCAL_DISCOVERY_PRIVET_HTTP_ASYNCHRONOUS_FACTORY_IMPL_H_
#define CHROME_BROWSER_LOCAL_DISCOVERY_PRIVET_HTTP_ASYNCHRONOUS_FACTORY_IMPL_H_
+#include "base/macros.h"
#include "chrome/browser/local_discovery/privet_http.h"
#include "chrome/browser/local_discovery/privet_http_asynchronous_factory.h"
-#include "chrome/common/local_discovery/service_discovery_client.h"
namespace local_discovery {
-class ServiceDiscoverySharedClient;
+class EndpointResolver;
class PrivetHTTPAsynchronousFactoryImpl : public PrivetHTTPAsynchronousFactory {
public:
@@ -37,24 +37,18 @@ class PrivetHTTPAsynchronousFactoryImpl : public PrivetHTTPAsynchronousFactory {
const std::string& GetName() override;
private:
- void ServiceResolveComplete(const ResultCallback& callback,
- ServiceResolver::RequestStatus result,
- const ServiceDescription& description);
-
- void DomainResolveComplete(uint16 port,
- const ResultCallback& callback,
- bool success,
- const net::IPAddressNumber& address_ipv4,
- const net::IPAddressNumber& address_ipv6);
-
+ void ResolveComplete(const ResultCallback& callback,
+ const net::IPEndPoint& endpoint);
std::string name_;
scoped_refptr<net::URLRequestContextGetter> request_context_;
- scoped_refptr<ServiceDiscoverySharedClient> service_discovery_client_;
- scoped_ptr<ServiceResolver> service_resolver_;
- scoped_ptr<LocalDomainResolver> domain_resolver_;
+ scoped_ptr<EndpointResolver> endpoint_resolver_;
+
+ DISALLOW_COPY_AND_ASSIGN(ResolutionImpl);
};
scoped_refptr<net::URLRequestContextGetter> request_context_;
+
+ DISALLOW_COPY_AND_ASSIGN(PrivetHTTPAsynchronousFactoryImpl);
};
} // namespace local_discovery

Powered by Google App Engine
This is Rietveld 408576698