Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1442843004: Oilpan: tidy up ChromeClientImplTest's ChromeClientImpl ref. (Closed)

Created:
5 years, 1 month ago by sof
Modified:
5 years, 1 month ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: tidy up ChromeClientImplTest's ChromeClientImpl ref. R=haraken BUG=553613 Committed: https://crrev.com/9afe442107ba0810cb0d7847296b9e21d58aa7cf Cr-Commit-Position: refs/heads/master@{#359748}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 10 (4 generated)
sof
5 years, 1 month ago (2015-11-14 07:12:45 UTC) #2
haraken
LGTM https://codereview.chromium.org/1442843004/diff/1/third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp File third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp (right): https://codereview.chromium.org/1442843004/diff/1/third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp#newcode122 third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp:122: RawPtrWillBePersistent<ChromeClientImpl> m_chromeClientImpl; RefPtrWillBePersistent?
5 years, 1 month ago (2015-11-14 07:14:16 UTC) #4
sof
https://codereview.chromium.org/1442843004/diff/1/third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp File third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp (right): https://codereview.chromium.org/1442843004/diff/1/third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp#newcode122 third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp:122: RawPtrWillBePersistent<ChromeClientImpl> m_chromeClientImpl; On 2015/11/14 07:14:16, haraken wrote: > > ...
5 years, 1 month ago (2015-11-14 08:12:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1442843004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1442843004/1
5 years, 1 month ago (2015-11-14 08:12:57 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-15 02:33:07 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-15 02:34:27 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9afe442107ba0810cb0d7847296b9e21d58aa7cf
Cr-Commit-Position: refs/heads/master@{#359748}

Powered by Google App Engine
This is Rietveld 408576698